| Message ID | 1400855960-22033-1-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 23.05.2014 16:39, Tomasz Figa wrote: > This patch fixes reg entry sizes in GIC node that were not large enough > to cover whole regions. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index b8ece4b..fbaf426 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -113,7 +113,7 @@ > compatible = "arm,cortex-a9-gic"; > #interrupt-cells = <3>; > interrupt-controller; > - reg = <0x10490000 0x1000>, <0x10480000 0x100>; > + reg = <0x10490000 0x10000>, <0x10480000 0x10000>; > }; > > combiner: interrupt-controller@10440000 { > Ping. Best regards, Tomasz
On 05/30/14 20:41, Tomasz Figa wrote: > Hi, > > On 23.05.2014 16:39, Tomasz Figa wrote: >> This patch fixes reg entry sizes in GIC node that were not large enough >> to cover whole regions. >> >> Signed-off-by: Tomasz Figa<t.figa@samsung.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index b8ece4b..fbaf426 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -113,7 +113,7 @@ >> compatible = "arm,cortex-a9-gic"; >> #interrupt-cells =<3>; >> interrupt-controller; >> - reg =<0x10490000 0x1000>,<0x10480000 0x100>; >> + reg =<0x10490000 0x10000>,<0x10480000 0x10000>; >> }; >> >> combiner: interrupt-controller@10440000 { >> > > Ping. > Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT support. Applied, but I need to check this is required for stable tree... Thanks, Kukjin
Hi Kukjin, On 30.05.2014 20:18, Kukjin Kim wrote: > On 05/30/14 20:41, Tomasz Figa wrote: >> Hi, >> >> On 23.05.2014 16:39, Tomasz Figa wrote: >>> This patch fixes reg entry sizes in GIC node that were not large enough >>> to cover whole regions. >>> >>> Signed-off-by: Tomasz Figa<t.figa@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos4.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >>> index b8ece4b..fbaf426 100644 >>> --- a/arch/arm/boot/dts/exynos4.dtsi >>> +++ b/arch/arm/boot/dts/exynos4.dtsi >>> @@ -113,7 +113,7 @@ >>> compatible = "arm,cortex-a9-gic"; >>> #interrupt-cells =<3>; >>> interrupt-controller; >>> - reg =<0x10490000 0x1000>,<0x10480000 0x100>; >>> + reg =<0x10490000 0x10000>,<0x10480000 0x10000>; >>> }; >>> >>> combiner: interrupt-controller@10440000 { >>> >> >> Ping. >> > Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT > support. Applied, but I need to check this is required for stable tree... Not sure if you already managed, but I think it might not be necessary in stable trees, as the (correct) static mapping is still there and it causes ioremap() to return correctly mapped area, ignoring the length specified in device tree. Best regards, Tomasz
On 06/11/14 00:28, Tomasz Figa wrote: > Hi Kukjin, > Hi Tomasz, > On 30.05.2014 20:18, Kukjin Kim wrote: >> On 05/30/14 20:41, Tomasz Figa wrote: >>> Hi, >>> >>> On 23.05.2014 16:39, Tomasz Figa wrote: >>>> This patch fixes reg entry sizes in GIC node that were not large enough >>>> to cover whole regions. >>>> >>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com> >>>> --- >>>> arch/arm/boot/dts/exynos4.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >>>> index b8ece4b..fbaf426 100644 >>>> --- a/arch/arm/boot/dts/exynos4.dtsi >>>> +++ b/arch/arm/boot/dts/exynos4.dtsi >>>> @@ -113,7 +113,7 @@ >>>> compatible = "arm,cortex-a9-gic"; >>>> #interrupt-cells =<3>; >>>> interrupt-controller; >>>> - reg =<0x10490000 0x1000>,<0x10480000 0x100>; >>>> + reg =<0x10490000 0x10000>,<0x10480000 0x10000>; >>>> }; >>>> >>>> combiner: interrupt-controller@10440000 { >>>> >>> >>> Ping. >>> >> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT >> support. Applied, but I need to check this is required for stable tree... > > Not sure if you already managed, but I think it might not be necessary > in stable trees, as the (correct) static mapping is still there and it > causes ioremap() to return correctly mapped area, ignoring the length > specified in device tree. > Yes, agreed. this is not required for stable tree... Thanks, Kukjin
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index b8ece4b..fbaf426 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -113,7 +113,7 @@ compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; interrupt-controller; - reg = <0x10490000 0x1000>, <0x10480000 0x100>; + reg = <0x10490000 0x10000>, <0x10480000 0x10000>; }; combiner: interrupt-controller@10440000 {
This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions. Signed-off-by: Tomasz Figa <t.figa@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)