From patchwork Wed Jun 4 15:01:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 4294951 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E29639F1D6 for ; Wed, 4 Jun 2014 15:07:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1BAB820172 for ; Wed, 4 Jun 2014 15:07:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 737ED20218 for ; Wed, 4 Jun 2014 15:07:14 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WsCk2-0007EY-3l; Wed, 04 Jun 2014 15:04:38 +0000 Received: from mail-wg0-f47.google.com ([74.125.82.47]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WsChv-0004US-JQ for linux-arm-kernel@lists.infradead.org; Wed, 04 Jun 2014 15:02:29 +0000 Received: by mail-wg0-f47.google.com with SMTP id x12so8487201wgg.6 for ; Wed, 04 Jun 2014 08:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9XIHkMEeLR2+rs9Mi8H1TXWX9AXPnslv89hjICzdSiU=; b=mt9ZI7xVO1iCXjX9QJLKK3o12VY7fQXMyzDEqJoilO9XzawKSKdH/Zvde5u5VuYPU8 ew51UsusDqrCrNuY2vQKfiZhKewIqwx9qLw4GGHtuGaTq2cSrM36g2AR7+r7qp4ACpnk MZfzynMxCNMm6asOt8fUlPDY+IqXXDGsKEMb8cvmNqgaDgdPX/Bb/b2sMC9ygw+kYNzx PQqYNJrgjXSP4c1gJJb5PbcAJNDRVim2w7BHrnWOU0rX+VOgRVJIR7TXcsQTlBQJVYJq KNjGScmVp1oy4WiDnIQuWT7rGtZMaE53YZNgdViGvL6iNDcW7RA+vtef7Q4aIagaCBLF QfXw== X-Gm-Message-State: ALoCoQmWkgd2kP+GR6iyBQJjwRPVwSg28E6yWZ0gX+dohjeGlbSC3qKO5hk0W6YRLeYVxHmTr5dR X-Received: by 10.194.186.210 with SMTP id fm18mr5834173wjc.67.1401894125125; Wed, 04 Jun 2014 08:02:05 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id vc2sm4097654wjc.2.2014.06.04.08.02.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jun 2014 08:02:03 -0700 (PDT) From: Daniel Thompson To: Thomas Gleixner , Jason Cooper Subject: [PATCH v2] irqchip: nvic: Use the generic noop function Date: Wed, 4 Jun 2014 16:01:52 +0100 Message-Id: <1401894112-13386-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1401885425-12378-1-git-send-email-daniel.thompson@linaro.org> References: <1401885425-12378-1-git-send-email-daniel.thompson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140604_080227_800727_488969FA X-CRM114-Status: GOOD ( 12.92 ) X-Spam-Score: -0.7 (/) Cc: Daniel Thompson , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the generic function saves looking up this custom one in a source navigator. Signed-off-by: Daniel Thompson Cc: Thomas Gleixner Cc: Jason Cooper --- drivers/irqchip/irq-nvic.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 70bdf6e..4ff0805 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) handle_IRQ(irq, regs); } -static void nvic_eoi(struct irq_data *d) -{ - /* - * This is a no-op as end of interrupt is signaled by the exception - * return sequence. - */ -} - static int __init nvic_of_init(struct device_node *node, struct device_node *parent) { @@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node, gc->chip_types[0].regs.disable = NVIC_ICER; gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg; gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg; - gc->chip_types[0].chip.irq_eoi = nvic_eoi; + /* This is a no-op as end of interrupt is signaled by the + * exception return sequence. + */ + gc->chip_types[0].chip.irq_eoi = irq_gc_noop; /* disable interrupts */ writel_relaxed(~0, gc->reg_base + NVIC_ICER);