| Message ID | 1402574007-13987-11-git-send-email-r.sricharan@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote: > From: Rajendra Nayak <rnayak@ti.com> > > On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ, > IRQ133 is default mapped to NMI pin, 139 and 140 crossbars are > unused(not routed). Mark these as unused crossbar IRQs. > > Technical Reference Manual documentation update expected > DRA72x-TRMINC00067 is being used to track the update. > > Reported-by: Nishanth Menon <nm@ti.com> > Reported-by: Sricharan R <r.sricharan@ti.com> > Reported-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Rajendra Nayak <rnayak@ti.com> > --- > drivers/irqchip/irq-crossbar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c > index 7d4db07..42a2e62 100644 > --- a/drivers/irqchip/irq-crossbar.c > +++ b/drivers/irqchip/irq-crossbar.c > @@ -253,8 +253,8 @@ err1: > return -ENOMEM; > } > > -/* irq number 10 cannot be used because of hw bug */ > -static int dra_irqs_unused[] = { 10 }; > +/* irq number 10,133,139 and 140 cannot be used because of hw bug */ > +static int dra_irqs_unused[] = { 10 , 133, 139, 140 }; see my earlier comment regarding a potential dts property. thx, Jason. > static struct crossbar_data cb_dra_data = { dra_irqs_unused, > ARRAY_SIZE(dra_irqs_unused), 0 }; > > -- > 1.7.9.5 >
Hi Jason, On Thursday 12 June 2014 06:46 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote: >> From: Rajendra Nayak <rnayak@ti.com> >> >> On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ, >> IRQ133 is default mapped to NMI pin, 139 and 140 crossbars are >> unused(not routed). Mark these as unused crossbar IRQs. >> >> Technical Reference Manual documentation update expected >> DRA72x-TRMINC00067 is being used to track the update. >> >> Reported-by: Nishanth Menon <nm@ti.com> >> Reported-by: Sricharan R <r.sricharan@ti.com> >> Reported-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Rajendra Nayak <rnayak@ti.com> >> --- >> drivers/irqchip/irq-crossbar.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c >> index 7d4db07..42a2e62 100644 >> --- a/drivers/irqchip/irq-crossbar.c >> +++ b/drivers/irqchip/irq-crossbar.c >> @@ -253,8 +253,8 @@ err1: >> return -ENOMEM; >> } >> >> -/* irq number 10 cannot be used because of hw bug */ >> -static int dra_irqs_unused[] = { 10 }; >> +/* irq number 10,133,139 and 140 cannot be used because of hw bug */ >> +static int dra_irqs_unused[] = { 10 , 133, 139, 140 }; > > see my earlier comment regarding a potential dts property. > Ok, if dts would be the better approach then I can change this. Regards, Sricharan
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 7d4db07..42a2e62 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -253,8 +253,8 @@ err1: return -ENOMEM; } -/* irq number 10 cannot be used because of hw bug */ -static int dra_irqs_unused[] = { 10 }; +/* irq number 10,133,139 and 140 cannot be used because of hw bug */ +static int dra_irqs_unused[] = { 10 , 133, 139, 140 }; static struct crossbar_data cb_dra_data = { dra_irqs_unused, ARRAY_SIZE(dra_irqs_unused), 0 };