| Message ID | 1403110635-29696-1-git-send-email-pali.rohar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 18, 2014 at 06:57:15PM +0200, Pali Rohár wrote: > Use same name as in legacy board code. There are lot of userspace > applications which using machine/model name for determinating device type. Can you clarify this? Nokia kernel or userspace never had DT, so they cannot see e.g. /proc/device-tree/model. What other APIs expose model? A.
On Wednesday 18 June 2014 22:12:41 Aaro Koskinen wrote: > On Wed, Jun 18, 2014 at 06:57:15PM +0200, Pali Rohár wrote: > > Use same name as in legacy board code. There are lot of > > userspace applications which using machine/model name for > > determinating device type. > > Can you clarify this? Nokia kernel or userspace never had DT, > so they cannot see e.g. /proc/device-tree/model. What other > APIs expose model? > > A. Hi Aaro, look at email discussion about my previous patch with subject: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible Basically that patch export model name in Hardware /proc/cpuinfo instead generic DT name. And this patch change name to what legacy board code reported.
Hi, On Wed, Jun 18, 2014 at 10:23:03PM +0200, Pali Rohár wrote: > On Wednesday 18 June 2014 22:12:41 Aaro Koskinen wrote: > > On Wed, Jun 18, 2014 at 06:57:15PM +0200, Pali Rohár wrote: > > > Use same name as in legacy board code. There are lot of > > > userspace applications which using machine/model name for > > > determinating device type. > > > > Can you clarify this? Nokia kernel or userspace never had DT, > > so they cannot see e.g. /proc/device-tree/model. What other > > APIs expose model? > > Basically that patch export model name in Hardware /proc/cpuinfo > instead generic DT name. And this patch change name to what > legacy board code reported. I don't like the idea of changing the model name from Nokia marketing names to those cryptic internal names in DT files. There also may be already some userspace relying to find current model name from /proc/device-tree/model (e.g. I think my own OS would break). A.
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 6c6551a..e23ee96 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -13,7 +13,7 @@ #include <dt-bindings/input/input.h> / { - model = "Nokia N900"; + model = "Nokia RX-51 board"; compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3"; aliases {
Use same name as in legacy board code. There are lot of userspace applications which using machine/model name for determinating device type. And changing this name will break all of them. Due to small features support in DT code only non DT kernel was used for Nokia N900 until now. Signed-off-by: Pali Rohár <pali.rohar@gmail.com> --- arch/arm/boot/dts/omap3-n900.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)