From patchwork Thu Jun 19 05:21:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 4380671 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E20B99F1C4 for ; Thu, 19 Jun 2014 05:24:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1556220384 for ; Thu, 19 Jun 2014 05:24:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33E4720320 for ; Thu, 19 Jun 2014 05:24:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WxUnG-0002AF-Gl; Thu, 19 Jun 2014 05:21:50 +0000 Received: from mail-yh0-f74.google.com ([209.85.213.74]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WxUnE-0001y6-46 for linux-arm-kernel@lists.infradead.org; Thu, 19 Jun 2014 05:21:48 +0000 Received: by mail-yh0-f74.google.com with SMTP id b6so252876yha.5 for ; Wed, 18 Jun 2014 22:21:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=poVGIFKE5iWpsX+MO1iBbzKTs+wjR3csi8yaGCA5Y2c=; b=TqPfiMCpeA5N9znh1Qk8wH4A+J/Ovzf3feaMkJCjvbCwuWPQJcewahpIOYZLkZc/1I h9S7+14VwaWfnjMAPar8nj9WVLt9/CBTVQ33B0rAX7IeVshzkCeA/W6CU+8Xp7qhqlEA SDhTVTSeI3xOlp8I0K5WCl4W6Q0A2Fi87sqvzR4yAId9jBx4FJM58Q+PA0/NGHkpxXjX kL2aCsDLqEfN6HfzeDkypkDxctMdraEbXb8hCfG0C/6Y5jGDqyYZeFeyHpQBaLBzY/Q6 mz7OiAwlmfIKKo/+H5NylzyxjT8Td6PQbr1EBkwpJv0Rm2sVNe55jB4zkzZJglvskGB2 EObQ== X-Gm-Message-State: ALoCoQkru93xNL7BTHY9KS/DM5wKsP+3/x/KEz7TXgr1BP9ZHrWC7ZdrBsRLNr5Go3mDuu1KOpDl X-Received: by 10.236.47.163 with SMTP id t23mr1217685yhb.41.1403155283598; Wed, 18 Jun 2014 22:21:23 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id j5si304955yhi.1.2014.06.18.22.21.23 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Jun 2014 22:21:23 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.72.141]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 70C2031C525; Wed, 18 Jun 2014 22:21:23 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 12C9D808AF; Wed, 18 Jun 2014 22:21:22 -0700 (PDT) From: Doug Anderson To: Wolfram Sang , Kukjin Kim Subject: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume Date: Wed, 18 Jun 2014 22:21:13 -0700 Message-Id: <1403155273-1057-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.0.0.526.g5318336 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140618_222148_248429_FB303877 X-CRM114-Status: GOOD ( 12.73 ) X-Spam-Score: -0.7 (/) Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, sjg@google.com, linux-kernel@vger.kernel.org, jg1.han@samsung.com, Doug Anderson , Tomasz Figa , standby24x7@gmail.com, paul.gortmaker@windriver.com, linux-i2c@vger.kernel.org, ch.naveen@samsung.com, javier.martinez@collabora.co.uk, jdelvare@suse.de, sachin.kamat@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The original code for the exynos i2c controller registered for the "noirq" variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no longer actually "noirq" (despite functions named exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq). i2c controllers that might have wakeup sources on them seem to need to resume at noirq time so that the individual drivers can actually read the i2c bus to handle their wakeup. NOTE: I took the original review feedback from Wolfram and added poweroff, thaw, freeze, restore. This patch has only been compile-tested since I don't have all the patches needed to make my machine using this i2c driver actually suspend/resume. Signed-off-by: Doug Anderson --- drivers/i2c/busses/i2c-exynos5.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c index 63d2292..cba740c 100644 --- a/drivers/i2c/busses/i2c-exynos5.c +++ b/drivers/i2c/busses/i2c-exynos5.c @@ -789,8 +789,14 @@ static int exynos5_i2c_resume_noirq(struct device *dev) } #endif -static SIMPLE_DEV_PM_OPS(exynos5_i2c_dev_pm_ops, exynos5_i2c_suspend_noirq, - exynos5_i2c_resume_noirq); +const struct dev_pm_ops exynos5_i2c_dev_pm_ops = { + .suspend_noirq = exynos5_i2c_suspend_noirq, + .resume_noirq = exynos5_i2c_resume_noirq, + .freeze_noirq = exynos5_i2c_suspend_noirq, + .thaw_noirq = exynos5_i2c_resume_noirq, + .poweroff_noirq = exynos5_i2c_suspend_noirq, + .restore_noirq = exynos5_i2c_resume_noirq, +}; static struct platform_driver exynos5_i2c_driver = { .probe = exynos5_i2c_probe,