From patchwork Wed Jun 25 12:28:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4420021 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CC7BFBEEAA for ; Wed, 25 Jun 2014 12:30:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 115162037B for ; Wed, 25 Jun 2014 12:30:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2607220379 for ; Wed, 25 Jun 2014 12:30:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WzmIw-0000oo-Jc; Wed, 25 Jun 2014 12:27:58 +0000 Received: from mail-wg0-f51.google.com ([74.125.82.51]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WzmIs-0000jo-MQ for linux-arm-kernel@lists.infradead.org; Wed, 25 Jun 2014 12:27:56 +0000 Received: by mail-wg0-f51.google.com with SMTP id x12so1960773wgg.10 for ; Wed, 25 Jun 2014 05:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wjVX1/b/nC/c0rVnZjXguROmSly8eiV5TMBXdrb0pXo=; b=OYdTL0egbjO0ur2qvsftMr3JuDIOG8Hz6Gjx3R+pLQo9Gce7NDTiuUlX0fahx2ZE1a NfrxMpZm5+aBJmFYsAh6zhzdJI7OftY0DKPgGcLQiH7gT4x9EG2Ujknju3XQOptdLmR2 nh6vEk4ZZLC8S39jaM/MniQQpeNkkc3jbGlntPCrupHEWb1vQz+zuGbmo+ywV5E+AW8k edkM5MElG212XEb3pxgit5NtvndChhvYR+kfLx0UJZ1sd7pNfgYLhOisMlA+OMMct0oT lzQcqv/ygjlQE2vIZESqJ1mQhZNUr2zlwVIDNuVlhM81Xt+5hBopasGDCD67F2OqXkRz L23g== X-Gm-Message-State: ALoCoQkmJRcBpwZhHCe9NQUnpRxXxLTgTGjnBiy9S45qwVbDchBZdvcLcLweUlcWTb1fA9bO4Gz/ X-Received: by 10.194.77.103 with SMTP id r7mr9380880wjw.67.1403699247535; Wed, 25 Jun 2014 05:27:27 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id lo18sm11909988wic.1.2014.06.25.05.27.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 05:27:26 -0700 (PDT) From: Rickard Strandqvist To: Felipe Balbi , Tony Lindgren Subject: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once Date: Wed, 25 Jun 2014 14:28:30 +0200 Message-Id: <1403699310-22960-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140625_052754_876207_ECA3354D X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) Cc: Russell King , Rickard Strandqvist , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist Acked-by: Felipe Balbi --- arch/arm/mach-omap2/usb-tusb6010.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c index e832bc7..8333400 100644 --- a/arch/arm/mach-omap2/usb-tusb6010.c +++ b/arch/arm/mach-omap2/usb-tusb6010.c @@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps) dev_t.t_avdp_w = t_scsnh_advnh; dev_t.cyc_aavdh_we = 3; dev_t.cyc_wpl = 6; - dev_t.t_ce_rdyz = 7000; gpmc_calc_timings(&t, &tusb_sync, &dev_t);