| Message ID | 1404324218-4743-3-git-send-email-lauraa@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 02, 2014 at 07:03:35PM +0100, Laura Abbott wrote: > > After allocating an address from a particular genpool, > there is no good way to verify if that address actually > belongs to a genpool. Introduce addr_in_gen_pool which > will return if an address plus size falls completely > within the genpool range. > > Signed-off-by: Laura Abbott <lauraa@codeaurora.org> > --- Acked-by: Will Deacon <will.deacon@arm.com> Will
On Wed, Jul 2, 2014 at 11:03 AM, Laura Abbott <lauraa@codeaurora.org> wrote: > > After allocating an address from a particular genpool, > there is no good way to verify if that address actually > belongs to a genpool. Introduce addr_in_gen_pool which > will return if an address plus size falls completely > within the genpool range. > > Signed-off-by: Laura Abbott <lauraa@codeaurora.org> Reviewed-by: Olof Johansson <olof@lixom.net> What's the merge path for this code? Part of the arm64 code that needs it, I presume? -Olof
On 7/9/2014 3:33 PM, Olof Johansson wrote: > On Wed, Jul 2, 2014 at 11:03 AM, Laura Abbott <lauraa@codeaurora.org> wrote: >> >> After allocating an address from a particular genpool, >> there is no good way to verify if that address actually >> belongs to a genpool. Introduce addr_in_gen_pool which >> will return if an address plus size falls completely >> within the genpool range. >> >> Signed-off-by: Laura Abbott <lauraa@codeaurora.org> > > Reviewed-by: Olof Johansson <olof@lixom.net> > > What's the merge path for this code? Part of the arm64 code that needs > it, I presume? > My plan was to have the entire series go through the arm64 tree unless someone has a better idea. Thanks, Laura
On Mon, Jul 21, 2014 at 08:51:04PM +0100, Laura Abbott wrote: > On 7/9/2014 3:33 PM, Olof Johansson wrote: > > On Wed, Jul 2, 2014 at 11:03 AM, Laura Abbott <lauraa@codeaurora.org> wrote: > >> > >> After allocating an address from a particular genpool, > >> there is no good way to verify if that address actually > >> belongs to a genpool. Introduce addr_in_gen_pool which > >> will return if an address plus size falls completely > >> within the genpool range. > >> > >> Signed-off-by: Laura Abbott <lauraa@codeaurora.org> > > > > Reviewed-by: Olof Johansson <olof@lixom.net> > > > > What's the merge path for this code? Part of the arm64 code that needs > > it, I presume? > > My plan was to have the entire series go through the arm64 tree unless > someone has a better idea. It's fine by me. But since it touches core arch/arm code, I would like to see an Ack from Russell.
diff --git a/include/linux/genalloc.h b/include/linux/genalloc.h index 3cd0934..1ccaab4 100644 --- a/include/linux/genalloc.h +++ b/include/linux/genalloc.h @@ -121,6 +121,9 @@ extern struct gen_pool *devm_gen_pool_create(struct device *dev, int min_alloc_order, int nid); extern struct gen_pool *dev_get_gen_pool(struct device *dev); +bool addr_in_gen_pool(struct gen_pool *pool, unsigned long start, + size_t size); + #ifdef CONFIG_OF extern struct gen_pool *of_get_named_gen_pool(struct device_node *np, const char *propname, int index); diff --git a/lib/genalloc.c b/lib/genalloc.c index c2b3ad7..6f03722 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -403,6 +403,35 @@ void gen_pool_for_each_chunk(struct gen_pool *pool, EXPORT_SYMBOL(gen_pool_for_each_chunk); /** + * addr_in_gen_pool - checks if an address falls within the range of a pool + * @pool: the generic memory pool + * @start: start address + * @size: size of the region + * + * Check if the range of addresses falls within the specified pool. Takes + * the rcu_read_lock for the duration of the check. + */ +bool addr_in_gen_pool(struct gen_pool *pool, unsigned long start, + size_t size) +{ + bool found = false; + unsigned long end = start + size; + struct gen_pool_chunk *chunk; + + rcu_read_lock(); + list_for_each_entry_rcu(chunk, &(pool)->chunks, next_chunk) { + if (start >= chunk->start_addr && start <= chunk->end_addr) { + if (end <= chunk->end_addr) { + found = true; + break; + } + } + } + rcu_read_unlock(); + return found; +} + +/** * gen_pool_avail - get available free space of the pool * @pool: pool to get available free space *
After allocating an address from a particular genpool, there is no good way to verify if that address actually belongs to a genpool. Introduce addr_in_gen_pool which will return if an address plus size falls completely within the genpool range. Signed-off-by: Laura Abbott <lauraa@codeaurora.org> --- include/linux/genalloc.h | 3 +++ lib/genalloc.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+)