| Message ID | 1407145537-15027-1-git-send-email-jingchang.lu@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I think you should cc also linuxppc-dev as it touches common code. On 08/04/2014 12:45 PM, Jingchang Lu wrote: > Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com> > --- > drivers/clk/Kconfig | 7 ++++--- > drivers/clk/clk-ppc-corenet.c | 5 +++++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index cfd3af7..8784704 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN > FPGAs. It is commonly used in Analog Devices' reference designs. > > config CLK_PPC_CORENET > - bool "Clock driver for PowerPC corenet platforms" > - depends on PPC_E500MC && OF > + bool "Clock driver for PowerPC corenet and compatible ARM-based platforms" > + depends on (PPC_E500MC || ARM) && OF > ---help--- > This adds the clock driver support for Freescale PowerPC corenet > - platforms using common clock framework. > + platforms and compatible Freescale ARM based platforms using common > + clock framework. > > config COMMON_CLK_XGENE > bool "Clock driver for APM XGene SoC" > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c Can't this file be renamed in order to reflect that is common between PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel. > index 8e58edf..7692cac 100644 > --- a/drivers/clk/clk-ppc-corenet.c > +++ b/drivers/clk/clk-ppc-corenet.c > @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void) > return platform_driver_register(&ppc_corenet_clk_driver); > } > subsys_initcall(ppc_corenet_clk_init); > + > +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init); > +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init); > +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init); Diana
>-----Original Message----- >From: Diana Craciun [mailto:diana.craciun@freescale.com] >Sent: Thursday, August 21, 2014 7:28 PM >To: Lu Jingchang-B35083 >Cc: mturquette@linaro.org; linux-kernel@vger.kernel.org; linux-arm- >kernel@lists.infradead.org >Subject: Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms >CLK_OF_DECLARE support > >I think you should cc also linuxppc-dev as it touches common code. > Ok, thanks, I will resend the patch and cc linuppc-dev. Best Regards, Jingchang
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index cfd3af7..8784704 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN FPGAs. It is commonly used in Analog Devices' reference designs. config CLK_PPC_CORENET - bool "Clock driver for PowerPC corenet platforms" - depends on PPC_E500MC && OF + bool "Clock driver for PowerPC corenet and compatible ARM-based platforms" + depends on (PPC_E500MC || ARM) && OF ---help--- This adds the clock driver support for Freescale PowerPC corenet - platforms using common clock framework. + platforms and compatible Freescale ARM based platforms using common + clock framework. config COMMON_CLK_XGENE bool "Clock driver for APM XGene SoC" diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c index 8e58edf..7692cac 100644 --- a/drivers/clk/clk-ppc-corenet.c +++ b/drivers/clk/clk-ppc-corenet.c @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void) return platform_driver_register(&ppc_corenet_clk_driver); } subsys_initcall(ppc_corenet_clk_init); + +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init); +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init); +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init); +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);
Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com> --- drivers/clk/Kconfig | 7 ++++--- drivers/clk/clk-ppc-corenet.c | 5 +++++ 2 files changed, 9 insertions(+), 3 deletions(-)