| Message ID | 1408106416-19044-3-git-send-email-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 15, 2014 at 01:40:09PM +0100, Peter Griffin wrote: > Currently this driver is missing a check on the return value of devm_kzalloc, > which would cause a NULL pointer dereference in a OOM situation. > > This patch adds the aformentioned missing check. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Acked-by: Andrew Lunn <andrew@lunn.ch> Thanks Andrew > --- > drivers/phy/phy-mvebu-sata.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c > index cc3c0e1..10bb8e5 100644 > --- a/drivers/phy/phy-mvebu-sata.c > +++ b/drivers/phy/phy-mvebu-sata.c > @@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev) > struct phy *phy; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > priv->base = devm_ioremap_resource(&pdev->dev, res); > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/drivers/phy/phy-mvebu-sata.c b/drivers/phy/phy-mvebu-sata.c index cc3c0e1..10bb8e5 100644 --- a/drivers/phy/phy-mvebu-sata.c +++ b/drivers/phy/phy-mvebu-sata.c @@ -89,6 +89,8 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev) struct phy *phy; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); priv->base = devm_ioremap_resource(&pdev->dev, res);
Currently this driver is missing a check on the return value of devm_kzalloc, which would cause a NULL pointer dereference in a OOM situation. This patch adds the aformentioned missing check. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- drivers/phy/phy-mvebu-sata.c | 2 ++ 1 file changed, 2 insertions(+)