diff mbox

ARM: dts: sun6i: Add #address-cells & #size-cells to i2c node

Message ID 1408456982-27021-1-git-send-email-ijc@hellion.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Campbell Aug. 19, 2014, 2:03 p.m. UTC
This fixes:
  DTC     arch/arm/boot/dts/sun6i-a31-hummingbird.dtb
Warning (reg_format): "reg" property in /soc@01c00000/i2c@01c2b400/rtc@51 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc@01c00000/i2c@01c2b400/rtc@51
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc@01c00000/i2c@01c2b400/rtc@51

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/sun6i-a31.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chen-Yu Tsai Aug. 19, 2014, 2:08 p.m. UTC | #1
Hi,

On Tue, Aug 19, 2014 at 10:03 PM, Ian Campbell <ijc@hellion.org.uk> wrote:
> This fixes:
>   DTC     arch/arm/boot/dts/sun6i-a31-hummingbird.dtb
> Warning (reg_format): "reg" property in /soc@01c00000/i2c@01c2b400/rtc@51 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc@01c00000/i2c@01c2b400/rtc@51
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc@01c00000/i2c@01c2b400/rtc@51

I submitted a fix for this just before the merge window.
I don't know why it didn't get into 3.17. Maxime did send a pull request for it.

See: https://patchwork.kernel.org/patch/4595851/

>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/sun6i-a31.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> index 44b07e5..5bc769f 100644
> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> @@ -680,6 +680,8 @@
>                         clock-frequency = <100000>;
>                         resets = <&apb2_rst 2>;
>                         status = "disabled";
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
>                 };
>
>                 i2c3: i2c@01c2b800 {
> --
> 2.0.1
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 44b07e5..5bc769f 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -680,6 +680,8 @@ 
 			clock-frequency = <100000>;
 			resets = <&apb2_rst 2>;
 			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
 		};
 
 		i2c3: i2c@01c2b800 {