| Message ID | 1409038230-7242-2-git-send-email-sjoerd.simons@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 26.08.2014 09:30, schrieb Sjoerd Simons: > In case the optional dr_mode property isn't set in the dwc3 nodes the > the controller will go into OTG mode iff both USB host and USB gadget > functionality are enabled in the kernel configuration. Unfortunately this > results in USB not working on exynos5420-peach-pit and > exynos5800-peach-pi with such a kernel configuration unless manually > change the mode. To resolve that explicitely configure the dual role "explicitly" > mode as host > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > --- > Changes in v2: alphabetically sort the dts entries > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 8 ++++++++ > 3 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 228a6b1..29d3a59 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -427,6 +427,14 @@ > status = "okay"; > }; > > +&usbdrd_dwc3_0 { > + dr_mode = "host"; > +}; > + > +&usbdrd_dwc3_1 { > + dr_mode = "host"; > +}; > + > &usbdrd_phy0 { > vbus-supply = <&usb300_vbus_reg>; > }; > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index bfe056d..8617a03 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -815,7 +815,7 @@ > #size-cells = <1>; > ranges; > > - dwc3 { > + usbdrd_dwc3_0: dwc3 { > compatible = "snps,dwc3"; > reg = <0x12000000 0x10000>; > interrupts = <0 72 0>; > @@ -841,7 +841,7 @@ > #size-cells = <1>; > ranges; > > - dwc3 { > + usbdrd_dwc3_1: dwc3 { > compatible = "snps,dwc3"; > reg = <0x12400000 0x10000>; > interrupts = <0 73 0>; > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index f3ee48b..2064550 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -425,6 +425,14 @@ > status = "okay"; > }; > > +&usbdrd_dwc3_0 { > + dr_mode = "host"; > +}; > + > +&usbdrd_dwc3_1 { > + dr_mode = "host"; > +}; > + > &usbdrd_phy0 { > vbus-supply = <&usb300_vbus_reg>; > }; Thanks, Reviewed-by: Andreas Färber <afaerber@suse.de> Andreas
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 228a6b1..29d3a59 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -427,6 +427,14 @@ status = "okay"; }; +&usbdrd_dwc3_0 { + dr_mode = "host"; +}; + +&usbdrd_dwc3_1 { + dr_mode = "host"; +}; + &usbdrd_phy0 { vbus-supply = <&usb300_vbus_reg>; }; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index bfe056d..8617a03 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -815,7 +815,7 @@ #size-cells = <1>; ranges; - dwc3 { + usbdrd_dwc3_0: dwc3 { compatible = "snps,dwc3"; reg = <0x12000000 0x10000>; interrupts = <0 72 0>; @@ -841,7 +841,7 @@ #size-cells = <1>; ranges; - dwc3 { + usbdrd_dwc3_1: dwc3 { compatible = "snps,dwc3"; reg = <0x12400000 0x10000>; interrupts = <0 73 0>; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index f3ee48b..2064550 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -425,6 +425,14 @@ status = "okay"; }; +&usbdrd_dwc3_0 { + dr_mode = "host"; +}; + +&usbdrd_dwc3_1 { + dr_mode = "host"; +}; + &usbdrd_phy0 { vbus-supply = <&usb300_vbus_reg>; };
In case the optional dr_mode property isn't set in the dwc3 nodes the the controller will go into OTG mode iff both USB host and USB gadget functionality are enabled in the kernel configuration. Unfortunately this results in USB not working on exynos5420-peach-pit and exynos5800-peach-pi with such a kernel configuration unless manually change the mode. To resolve that explicitely configure the dual role mode as host Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> --- Changes in v2: alphabetically sort the dts entries arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++++++++ arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- arch/arm/boot/dts/exynos5800-peach-pi.dts | 8 ++++++++ 3 files changed, 18 insertions(+), 2 deletions(-)