| Message ID | 1409132889-2080-6-git-send-email-ch.naveen@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote: > Samsung Exynos7 is a ARM64bit processor. Which does not select > the CONFIG_PLAT_SAMSUNG symbol. CONFIG_PINCTRL_SAMSUNG is being > selected for both PLAT_SAMSUNG and ARCH_EXYNOS7 symbols. > > This patch modifes the pinctrl/Makefile to use > CONFIG_PINCTRL_SAMSUNG symbol to compile the pinctrl/samsung/*.c > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: linus.walleij@linaro.org > Cc: Thomas Abraham <thomas.ab@samsung.com> Excellent catch, thanks, patch applied! I should use this pattern on more places in the Makefile, I was confused by logically thinking that Kconfig symbols used in Makefile cannot be from a Kconfig one level below. Yours, Linus Walleij
On 29 August 2014 18:07, Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi > <ch.naveen@samsung.com> wrote: > >> Samsung Exynos7 is a ARM64bit processor. Which does not select >> the CONFIG_PLAT_SAMSUNG symbol. CONFIG_PINCTRL_SAMSUNG is being >> selected for both PLAT_SAMSUNG and ARCH_EXYNOS7 symbols. >> >> This patch modifes the pinctrl/Makefile to use >> CONFIG_PINCTRL_SAMSUNG symbol to compile the pinctrl/samsung/*.c >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Tomasz Figa <t.figa@samsung.com> >> Cc: linus.walleij@linaro.org >> Cc: Thomas Abraham <thomas.ab@samsung.com> > > Excellent catch, thanks, patch applied! Thanks Linus. > > I should use this pattern on more places in the Makefile, > I was confused by logically thinking that Kconfig symbols > used in Makefile cannot be from a Kconfig one level below. > > Yours, > Linus Walleij
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 05d2275..801777e 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -58,7 +58,7 @@ obj-$(CONFIG_ARCH_BERLIN) += berlin/ obj-$(CONFIG_PLAT_ORION) += mvebu/ obj-y += nomadik/ obj-$(CONFIG_ARCH_QCOM) += qcom/ -obj-$(CONFIG_PLAT_SAMSUNG) += samsung/ +obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/ obj-$(CONFIG_ARCH_SHMOBILE) += sh-pfc/ obj-$(CONFIG_SUPERH) += sh-pfc/ obj-$(CONFIG_PLAT_SPEAR) += spear/
Samsung Exynos7 is a ARM64bit processor. Which does not select the CONFIG_PLAT_SAMSUNG symbol. CONFIG_PINCTRL_SAMSUNG is being selected for both PLAT_SAMSUNG and ARCH_EXYNOS7 symbols. This patch modifes the pinctrl/Makefile to use CONFIG_PINCTRL_SAMSUNG symbol to compile the pinctrl/samsung/*.c Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> Cc: Tomasz Figa <t.figa@samsung.com> Cc: linus.walleij@linaro.org Cc: Thomas Abraham <thomas.ab@samsung.com> --- drivers/pinctrl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)