| Message ID | 1409204060-9223-7-git-send-email-zhangfei.gao@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 8/28/14, 12:34 AM, Zhangfei Gao wrote: > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > --- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > index 152f3ad..7b1cb53 100644 > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > @@ -365,6 +365,15 @@ > #interrupt-cells = <2>; > status = "disabled"; > }; > + > + wdg0: wdg@a2c000 { A nit-pick here, but everybody else is using 'wdt' for a watchdog timer node. > + compatible = "arm,sp805", "arm,primecell"; I didn't see an entry for "arm,sp805" in Documentations, should there be one? Dinh > + arm,primecell-periphid = <0x00141805>; > + reg = <0xa2c000 0x1000>; > + interrupts = <0 29 4>; > + clocks = <&clock HIX5HD2_WDG0_RST>; > + clock-names = "apb_pclk"; > + }; > }; > > local_timer@00a00600 { >
On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote: > > > On 8/28/14, 12:34 AM, Zhangfei Gao wrote: > > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > > --- > > arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > index 152f3ad..7b1cb53 100644 > > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > @@ -365,6 +365,15 @@ > > #interrupt-cells = <2>; > > status = "disabled"; > > }; > > + > > + wdg0: wdg@a2c000 { > > A nit-pick here, but everybody else is using 'wdt' for a watchdog timer > node. > > > + compatible = "arm,sp805", "arm,primecell"; > > I didn't see an entry for "arm,sp805" in Documentations, should there be > one? There probably should, yes. It looks like only the sp804 is documented. Pawel, it looks like you were the first sp805,sp810 dt user. Care to put together a couple of documents? ;) Mark.
On 08/29/2014 01:12 AM, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote: >> >> >> On 8/28/14, 12:34 AM, Zhangfei Gao wrote: >>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> >>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> >>> --- >>> arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> index 152f3ad..7b1cb53 100644 >>> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> @@ -365,6 +365,15 @@ >>> #interrupt-cells = <2>; >>> status = "disabled"; >>> }; >>> + >>> + wdg0: wdg@a2c000 { >> >> A nit-pick here, but everybody else is using 'wdt' for a watchdog timer >> node. Sure?will change to wdt0: watchdog@a2c000 >> >>> + compatible = "arm,sp805", "arm,primecell"; >> >> I didn't see an entry for "arm,sp805" in Documentations, should there be >> one? > > There probably should, yes. It looks like only the sp804 is documented. > > Pawel, it looks like you were the first sp805,sp810 dt user. Care to put > together a couple of documents? ;) > Yes, that would be great, Not find bindings for drivers/watchdog/sp805_wdt.c. Thanks
diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 152f3ad..7b1cb53 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -365,6 +365,15 @@ #interrupt-cells = <2>; status = "disabled"; }; + + wdg0: wdg@a2c000 { + compatible = "arm,sp805", "arm,primecell"; + arm,primecell-periphid = <0x00141805>; + reg = <0xa2c000 0x1000>; + interrupts = <0 29 4>; + clocks = <&clock HIX5HD2_WDG0_RST>; + clock-names = "apb_pclk"; + }; }; local_timer@00a00600 {