From patchwork Tue Sep 2 23:02:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 4829291 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 07B79C0338 for ; Tue, 2 Sep 2014 23:06:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3252F201F2 for ; Tue, 2 Sep 2014 23:06:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49890201CE for ; Tue, 2 Sep 2014 23:06:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOx7n-0003yc-KX; Tue, 02 Sep 2014 23:04:31 +0000 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOx7h-0003s7-3K for linux-arm-kernel@lists.infradead.org; Tue, 02 Sep 2014 23:04:25 +0000 Received: by mail-pd0-f177.google.com with SMTP id r10so9590909pdi.8 for ; Tue, 02 Sep 2014 16:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=4z4aP4ix6bf9GURqa+n0SgztVgh+EiZnc0AmBGwVMug=; b=0aH4PCoeooD6QLJ3VQuG5XUqg6KCNkx4apiOOaDoGpHWxfyzFiOLmmmK0DwmZwNzfY n7HQMVbQnoGagAdoGD+xKrBbaJuYOeIM/cNnRTWW3ST2mqtc0x2/Uj0CFEdC6Dvwetsw 2HLpBmF40Gdazf0dfEkB2+U2J0bglV7/fVaXyERpH3oqSu5wVTfSP/YhY6RpfkWeDsi2 BIQB9ckBRYwS5T/edeYKfuKi4hPPSkfUiUY5wgNRJbfPD1vWNegrbXwBPllAtZgRYUgh do/Nh0u3Se8Hr/kww9vUMOtQqa9oDB9RzpO1ve0cCHFblHrAga5EU6pKLlfoalley7We xH5w== X-Received: by 10.67.13.176 with SMTP id ez16mr51669713pad.54.1409699044236; Tue, 02 Sep 2014 16:04:04 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id aq1sm4960949pbc.96.2014.09.02.16.04.02 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 16:04:03 -0700 (PDT) From: Soren Brinkmann To: Michal Simek , Mike Turquette Subject: [PATCH 1/3] clk: zynq: Remove unnecessary OOM message Date: Tue, 2 Sep 2014 16:02:07 -0700 Message-Id: <1409698929-30143-2-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.1.0.1.g27b9230 In-Reply-To: <1409698929-30143-1-git-send-email-soren.brinkmann@xilinx.com> References: <1409698929-30143-1-git-send-email-soren.brinkmann@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140902_160425_162562_CAF4E5CF X-CRM114-Status: GOOD ( 10.50 ) X-Spam-Score: -0.7 (/) Cc: Soren Brinkmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As checkpatch suggests: WARNING: Possible unnecessary 'out of memory' message, remove an error message after failing kmalloc() from the PLL driver. Signed-off-by: Soren Brinkmann --- drivers/clk/zynq/pll.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/zynq/pll.c b/drivers/clk/zynq/pll.c index cec97596fe65..00d72fb5c036 100644 --- a/drivers/clk/zynq/pll.c +++ b/drivers/clk/zynq/pll.c @@ -211,10 +211,8 @@ struct clk *clk_register_zynq_pll(const char *name, const char *parent, }; pll = kmalloc(sizeof(*pll), GFP_KERNEL); - if (!pll) { - pr_err("%s: Could not allocate Zynq PLL clk.\n", __func__); + if (!pll) return ERR_PTR(-ENOMEM); - } /* Populate the struct */ pll->hw.init = &initd;