diff mbox

[v2,1/4] ARM: docs: add documentation binding for meson watchdog

Message ID 1410984726-18944-2-git-send-email-carlo@caione.org (mailing list archive)
State New, archived
Headers show

Commit Message

Carlo Caione Sept. 17, 2014, 8:12 p.m. UTC
Signed-off-by: Carlo Caione <carlo@caione.org>
---
 Documentation/devicetree/bindings/watchdog/meson-wdt.txt | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/meson-wdt.txt

Comments

Beniamino Galvani Sept. 17, 2014, 8:58 p.m. UTC | #1
On Wed, Sep 17, 2014 at 10:12:03PM +0200, Carlo Caione wrote:
> Signed-off-by: Carlo Caione <carlo@caione.org>
> ---
>  Documentation/devicetree/bindings/watchdog/meson-wdt.txt | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> new file mode 100644
> index 0000000..e66c0c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> @@ -0,0 +1,13 @@
> +Meson SoCs Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "amlogic,meson-wdt"

Hi Carlo,

the compatible property should describe a specific version of the
device, so maybe "amlogic,meson6-wdt" would be more appropriate.

Beniamino

> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +wdt: watchdog@c1109900 {
> +	compatible = "amlogic,meson-wdt";
> +	reg = <0xc1109900 0x8>;
> +};
> -- 
> 1.9.1
>
Carlo Caione Sept. 19, 2014, 8:07 a.m. UTC | #2
On Wed, Sep 17, 2014 at 10:58 PM, Beniamino Galvani <b.galvani@gmail.com> wrote:
> On Wed, Sep 17, 2014 at 10:12:03PM +0200, Carlo Caione wrote:
>> Signed-off-by: Carlo Caione <carlo@caione.org>
>> ---
>>  Documentation/devicetree/bindings/watchdog/meson-wdt.txt | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/watchdog/meson-wdt.txt
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
>> new file mode 100644
>> index 0000000..e66c0c3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
>> @@ -0,0 +1,13 @@
>> +Meson SoCs Watchdog timer
>> +
>> +Required properties:
>> +
>> +- compatible : should be "amlogic,meson-wdt"
>
> Hi Carlo,
>
> the compatible property should describe a specific version of the
> device, so maybe "amlogic,meson6-wdt" would be more appropriate.

Agree. Fix in v3.

Thanks,
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
new file mode 100644
index 0000000..e66c0c3
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
@@ -0,0 +1,13 @@ 
+Meson SoCs Watchdog timer
+
+Required properties:
+
+- compatible : should be "amlogic,meson-wdt"
+- reg : Specifies base physical address and size of the registers.
+
+Example:
+
+wdt: watchdog@c1109900 {
+	compatible = "amlogic,meson-wdt";
+	reg = <0xc1109900 0x8>;
+};