| Message ID | 1411459730.20236.6.camel@x220 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 23, 2014 at 10:08 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > removed the only dependency that used it. Setting it had no effect > anymore. > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > some reason that commit did not remove all select statements for that > symbol. These statements are now useless. Remove one from shmobile too. The explanation for "some reason" is very simple: new selects were introduced in parallel with the removal of the existing ones. > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Sep 23, 2014 at 10:27:37AM +0200, Geert Uytterhoeven wrote: > On Tue, Sep 23, 2014 at 10:08 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > > removed the only dependency that used it. Setting it had no effect > > anymore. > > > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > > some reason that commit did not remove all select statements for that > > symbol. These statements are now useless. Remove one from shmobile too. > > The explanation for "some reason" is very simple: new selects were introduced > in parallel with the removal of the existing ones. > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued this up for v3.19. I will push it to a branch that will be included in linux-next once v3.18-rc1 has been released.
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index 21f457b56c01..f59019dd986e 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTI
The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore. So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from shmobile too. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Sent previously as part of the treewide patch "PM / OPP: Remove ARCH_HAS_OPP completely". But it turns out the changes for omap2 are already queued in omap-for-v3.18/soc (but not in linux-next!). Besides, Simon Horman wanted the shmobile change split off. Done on top of next-20140922. Tested by grepping the tree. arch/arm/mach-shmobile/Kconfig | 1 - 1 file changed, 1 deletion(-)