From patchwork Fri Sep 26 11:53:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jon Medhurst (Tixy)" X-Patchwork-Id: 4981861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9F8ABBEEA6 for ; Fri, 26 Sep 2014 11:56:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B13DA201DD for ; Fri, 26 Sep 2014 11:56:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B465B201BC for ; Fri, 26 Sep 2014 11:56:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XXU5y-0005JO-BR; Fri, 26 Sep 2014 11:53:54 +0000 Received: from smarthost01c.mail.zen.net.uk ([212.23.1.5]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XXU5u-0005G7-Fw for linux-arm-kernel@lists.infradead.org; Fri, 26 Sep 2014 11:53:51 +0000 Received: from [82.69.122.217] (helo=linaro1) by smarthost01c.mail.zen.net.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XXU5W-0005Q5-Oh; Fri, 26 Sep 2014 11:53:26 +0000 Message-ID: <1411732406.1529.20.camel@linaro1.home> Subject: Re: Kprobes build failure From: "Jon Medhurst (Tixy)" To: Russell King - ARM Linux Date: Fri, 26 Sep 2014 12:53:26 +0100 In-Reply-To: <1411725443.1529.10.camel@linaro1.home> References: <20140925233720.GG5182@n2100.arm.linux.org.uk> <1411725443.1529.10.camel@linaro1.home> X-Mailer: Evolution 3.12.2-1+b1 Mime-Version: 1.0 X-Originating-smarthost01c-IP: [82.69.122.217] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140926_045350_707703_012E3908 X-CRM114-Status: GOOD ( 20.48 ) X-Spam-Score: -0.7 (/) Cc: linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 2014-09-26 at 10:57 +0100, Jon Medhurst (Tixy) wrote: > On Fri, 2014-09-26 at 00:37 +0100, Russell King - ARM Linux wrote: > > So, Olof's kbuild found this while building my rc5 based for-next tree: > > > > arm.allmodconfig: > > /tmp/ccoT403o.s:21439: Error: bad immediate value for offset (4168) > > /tmp/ccoT403o.s:21440: Error: bad immediate value for offset (4176) > > /tmp/ccoT403o.s:21475: Error: bad immediate value for offset (4260) > > /tmp/ccoT403o.s:21476: Error: bad immediate value for offset (4260) > > /tmp/ccoT403o.s:23566: Error: bad immediate value for offset (4132) > > /tmp/ccoT403o.s:23567: Error: bad immediate value for offset (4148) > > /tmp/ccoT403o.s:23606: Error: bad immediate value for offset (4236) > > /tmp/ccoT403o.s:23607: Error: bad immediate value for offset (4248) > > > > which, when looking at the logs, appears to be: > > > > /tmp/ccoT403o.s:47583: Error: bad immediate value for offset (5464) > > make[3]: *** [arch/arm/kernel/kprobes-test-arm.o] Error 1 > > make[3]: Target `__build' not remade because of errors. > > make[2]: *** [arch/arm/kernel] Error 2 > > > > Any ideas? > > Sounds vaguely familiar as a problem I hit before. Google finds someone > else hitting similar problem [1] and the symptoms and cause match my > memories of the old kprobe issue. > > Where can I find a clue of to the config and compiler used in Olof's > build, so I can have a go at reproducing and debugging? I've now reproduced this and the cause _is_ the problem mentioned at the bottom of this email because the following diff fixes the issue (now need to try and think of a nicer and more robust fix...) > > [1] https://lkml.org/lkml/2012/9/24/223 > > The relevant explanation of the above post copied below... > > ------------------------------------------------------------------------ > > The compiler uses a pretty dumb heuristic to guess the size of asms: > 4 * (number of ; or \n in the string) > > Directives that the compiler can't predict the size of are not safe if > they output into any segment that the compiler uses. .fill/.skip are > obvious candidates, but macro expansions, .rept, .irp etc. can cause > these problems too. > > For example: > > void g(int); > void f(void) > { > g(0xd00dfeed); > asm(".skip 0x1000"); > } > If you try building this with gcc -marm -Os for example: > > /tmp/ccXYm1uP.s: Assembler messages: > /tmp/ccXYm1uP.s:21: Error: bad immediate value for offset (4100) > > ...because the assembler assumes that it can dump a literal at the end > of the function and reference it from the g() callsite. > > ------------------------------------------------------------------------ > > diff --git a/arch/arm/kernel/kprobes-test.h b/arch/arm/kernel/kprobes-test.h index eecc90a..783072d 100644 --- a/arch/arm/kernel/kprobes-test.h +++ b/arch/arm/kernel/kprobes-test.h @@ -113,7 +113,7 @@ struct test_arg_end { "bl __kprobes_test_case_start \n\t" \ /* don't use .asciz here as 'title' may be */ \ /* multiple strings to be concatenated. */ \ - ".ascii "#title" \n\t" \ + ".ascii "#title";;;;;;;;;;;;;;;;;;;; \n\t" \ ".byte 0 \n\t" \ ".align 2, 0 \n\t"