| Message ID | 1411796519-19417-3-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pankaj, On 27.09.2014 07:41, Pankaj Dubey wrote: > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Missing patch description. > --- > drivers/clk/samsung/clk.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c > index deab84d..31bf391 100644 > --- a/drivers/clk/samsung/clk.c > +++ b/drivers/clk/samsung/clk.c > @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx, > * obtain the clock speed of all external fixed clock sources from device > * tree and register it > */ > -#ifdef CONFIG_OF We still have non-DT platforms which use this code, i.e. s3c24xx and s3c64xx. Have you checked if this compiles fine on them with CONFIG_OF disabled? Best regards, Tomasz
Hi Tomasz, On Saturday, September 27, 2014 6:51 PM, Tomasz Figa wrote, > Hi Pankaj, > > On 27.09.2014 07:41, Pankaj Dubey wrote: > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > > Missing patch description. OK, will add it. > > > --- > > drivers/clk/samsung/clk.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c > > index deab84d..31bf391 100644 > > --- a/drivers/clk/samsung/clk.c > > +++ b/drivers/clk/samsung/clk.c > > @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct > samsung_clk_provider *ctx, > > * obtain the clock speed of all external fixed clock sources from device > > * tree and register it > > */ > > -#ifdef CONFIG_OF > > We still have non-DT platforms which use this code, i.e. s3c24xx and s3c64xx. Have > you checked if this compiles fine on them with CONFIG_OF disabled? > Compile tested with s3c2410_defconfig and s3c6400_defconfig, and its compiled fine. In both cases CONFIG_OF was disabled. Thanks, Pankaj Dubey > Best regards, > Tomasz
diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c index deab84d..31bf391 100644 --- a/drivers/clk/samsung/clk.c +++ b/drivers/clk/samsung/clk.c @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx, * obtain the clock speed of all external fixed clock sources from device * tree and register it */ -#ifdef CONFIG_OF void __init samsung_clk_of_register_fixed_ext(struct samsung_clk_provider *ctx, struct samsung_fixed_rate_clock *fixed_rate_clk, unsigned int nr_fixed_rate_clk, @@ -298,7 +297,6 @@ void __init samsung_clk_of_register_fixed_ext(struct samsung_clk_provider *ctx, } samsung_clk_register_fixed_rate(ctx, fixed_rate_clk, nr_fixed_rate_clk); } -#endif /* utility function to get the rate of a specified clock */ unsigned long _get_rate(const char *clk_name)
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- drivers/clk/samsung/clk.c | 2 -- 1 file changed, 2 deletions(-)