diff mbox

[RFC,10/16] mips: support poweroff through poweroff handler call chain

Message ID 1412100056-15517-11-git-send-email-linux@roeck-us.net (mailing list archive)
State New, archived
Headers show

Commit Message

Guenter Roeck Sept. 30, 2014, 6 p.m. UTC
The kernel core now supports a poweroff handler call chain
to remove power from the system. Call it if pm_power_off
is set to NULL.

Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/mips/kernel/reset.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ralf Baechle Oct. 1, 2014, 1:32 p.m. UTC | #1
On Tue, Sep 30, 2014 at 11:00:50AM -0700, Guenter Roeck wrote:

> The kernel core now supports a poweroff handler call chain
> to remove power from the system. Call it if pm_power_off
> is set to NULL.
> 
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  arch/mips/kernel/reset.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
> index 07fc524..c3391d7 100644
> --- a/arch/mips/kernel/reset.c
> +++ b/arch/mips/kernel/reset.c
> @@ -41,4 +41,6 @@ void machine_power_off(void)
>  {
>  	if (pm_power_off)
>  		pm_power_off();
> +	else
> +		do_kernel_poweroff();

I'm happy with this as long as in a later version pm_power_off indeed
goes away.

  Ralf
Guenter Roeck Oct. 1, 2014, 4:26 p.m. UTC | #2
On Wed, Oct 01, 2014 at 03:32:39PM +0200, Ralf Baechle wrote:
> On Tue, Sep 30, 2014 at 11:00:50AM -0700, Guenter Roeck wrote:
> 
> > The kernel core now supports a poweroff handler call chain
> > to remove power from the system. Call it if pm_power_off
> > is set to NULL.
> > 
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >  arch/mips/kernel/reset.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
> > index 07fc524..c3391d7 100644
> > --- a/arch/mips/kernel/reset.c
> > +++ b/arch/mips/kernel/reset.c
> > @@ -41,4 +41,6 @@ void machine_power_off(void)
> >  {
> >  	if (pm_power_off)
> >  		pm_power_off();
> > +	else
> > +		do_kernel_poweroff();
> 
> I'm happy with this as long as in a later version pm_power_off indeed
> goes away.
> 
Yes, that would be the ultimate goal. Hope we can get there.

Guenter
diff mbox

Patch

diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
index 07fc524..c3391d7 100644
--- a/arch/mips/kernel/reset.c
+++ b/arch/mips/kernel/reset.c
@@ -41,4 +41,6 @@  void machine_power_off(void)
 {
 	if (pm_power_off)
 		pm_power_off();
+	else
+		do_kernel_poweroff();
 }