From patchwork Tue Sep 30 18:00:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 5005931 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4789EBEEA6 for ; Tue, 30 Sep 2014 18:04:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 61BC8201C7 for ; Tue, 30 Sep 2014 18:04:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75AA62015D for ; Tue, 30 Sep 2014 18:04:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XZ1kX-0007aM-Ab; Tue, 30 Sep 2014 18:02:09 +0000 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XZ1jx-0007Hy-Vm for linux-arm-kernel@lists.infradead.org; Tue, 30 Sep 2014 18:01:34 +0000 Received: by mail-pa0-f52.google.com with SMTP id fb1so8028733pad.11 for ; Tue, 30 Sep 2014 11:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9PcH9vkqtbwsQEhiONThBwmzk2VQhEfeE7yLBkZxmg8=; b=SF6B8zhBABnJvHJcJpUhdlVKHl4srwi2kmAkFGImYdDKRg7wRv9uPAo8ouWn4WvJGc DfcKipMxk2k7unsqfOQ4D+YcPKOoQnkzscGCYFA6CffrqNlA9oF4n2Qg3B5iwLQ8/Kky TugkkGbVBhcSdRuaVY/oU5LjCwWnCesRw9EUANsHE9wNPAzP1SEpZIXS5QfumaFSYpLN UlJbdgjlZAFtlATlSNlNoixWS7w2y9aA8cvdaub7cONnDj+4mp1+3EIvBDUgbpbTt/VX nhlSV9jtGdgXBWVQ1F6hXoizor4KjQSOISt/2vWhFyDQ9h5oNelLtufDv56ROWV5M2Lc ksHQ== X-Received: by 10.69.20.10 with SMTP id gy10mr38012021pbd.119.1412100073196; Tue, 30 Sep 2014 11:01:13 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id n3sm6561773pda.7.2014.09.30.11.01.12 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 30 Sep 2014 11:01:12 -0700 (PDT) From: Guenter Roeck To: linux-kernel@vger.kernel.org Subject: [RFC PATCH 02/16] hwmon: (ab8500) Call kernel_power_off instead of pm_power_off Date: Tue, 30 Sep 2014 11:00:42 -0700 Message-Id: <1412100056-15517-3-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1412100056-15517-1-git-send-email-linux@roeck-us.net> References: <1412100056-15517-1-git-send-email-linux@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140930_110134_088121_925C0E72 X-CRM114-Status: GOOD ( 12.93 ) X-Spam-Score: 2.0 (++) Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org, Jean Delvare , Guenter Roeck , xen-devel@lists.xenproject.org, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SUSPICIOUS_RECIPS, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Drivers should not call pm_power_off directly; it is not guaranteed to be non-NULL. Call kernel_power_off instead. Cc: Jean Delvare Signed-off-by: Guenter Roeck --- I already submitted this patch separately as non-RFC. It is included in this series for completeness. drivers/hwmon/ab8500.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ab8500.c b/drivers/hwmon/ab8500.c index d844dc8..8b6a4f4 100644 --- a/drivers/hwmon/ab8500.c +++ b/drivers/hwmon/ab8500.c @@ -6,7 +6,7 @@ * * When the AB8500 thermal warning temperature is reached (threshold cannot * be changed by SW), an interrupt is set, and if no further action is taken - * within a certain time frame, pm_power off will be called. + * within a certain time frame, kernel_power_off will be called. * * When AB8500 thermal shutdown temperature is reached a hardware shutdown of * the AB8500 will occur. @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include "abx500.h" @@ -106,7 +107,7 @@ static void ab8500_thermal_power_off(struct work_struct *work) dev_warn(&abx500_data->pdev->dev, "Power off due to critical temp\n"); - pm_power_off(); + kernel_power_off(); } static ssize_t ab8500_show_name(struct device *dev,