| Message ID | 1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/10/14 15:29, Joe.C wrote: > From: "Joe.C" <yingjoe.chen@mediatek.com> > > Change virq type from unsigned int to int. Otherwise the return value > check for irq_domain_alloc_irqs will always pass. > > Signed-off-by: Joe.C <yingjoe.chen@mediatek.com> > --- > kernel/irq/irqdomain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 584be46..dd8d3ab 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) > struct irq_domain *domain; > irq_hw_number_t hwirq; > unsigned int type = IRQ_TYPE_NONE; > - unsigned int virq; > + int virq; > > domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain; > if (!domain) { > I'd expect this patch to get folded into Jiang's series. Thanks, M.
On 2014/10/13 20:11, Marc Zyngier wrote: > On 09/10/14 15:29, Joe.C wrote: >> From: "Joe.C" <yingjoe.chen@mediatek.com> >> >> Change virq type from unsigned int to int. Otherwise the return value >> check for irq_domain_alloc_irqs will always pass. >> >> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com> >> --- >> kernel/irq/irqdomain.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >> index 584be46..dd8d3ab 100644 >> --- a/kernel/irq/irqdomain.c >> +++ b/kernel/irq/irqdomain.c >> @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) >> struct irq_domain *domain; >> irq_hw_number_t hwirq; >> unsigned int type = IRQ_TYPE_NONE; >> - unsigned int virq; >> + int virq; >> >> domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain; >> if (!domain) { >> > > I'd expect this patch to get folded into Jiang's series. Hi Mark and Joe, Yes, my next version includes this fixup. Regards! Gerry > > Thanks, > > M. >
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 584be46..dd8d3ab 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) struct irq_domain *domain; irq_hw_number_t hwirq; unsigned int type = IRQ_TYPE_NONE; - unsigned int virq; + int virq; domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain; if (!domain) {