Message ID | 1413125679-24443-2-git-send-email-carlo@caione.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Sun, Oct 12, 2014 at 04:54:37PM +0200, Carlo Caione wrote: > This patch adds support for the reset controller found on the Amlogic > MesonX SoCs. For several devices in the AO (Always-On) power domain, it > is possible to reset them by programming a specific bit in a register. Hi Carlo, > [...] > + > +static int meson_reset_probe(struct platform_device *pdev) > +{ > + struct meson_reset_data *data; > + struct resource *res; > + > + /* > + * The binding was mainlined without the required property. > + * Do not continue, when we encounter an old DT. > + */ > + if (!of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) { > + dev_err(&pdev->dev, "%s missing #reset-cells property\n", > + pdev->dev.of_node->full_name); > + return -EINVAL; > + } Probably the above comment was taken from another driver but is not relevant here. > + > + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + data->membase = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(data->membase)) > + return PTR_ERR(data->membase); > + > + spin_lock_init(&data->lock); > + > + data->rcdev.owner = THIS_MODULE; > + data->rcdev.nr_resets = BITS_PER_LONG; > + data->rcdev.ops = &meson_reset_ops; > + data->rcdev.of_node = pdev->dev.of_node; > + reset_controller_register(&data->rcdev); > + > + return 0; > +} > + > +static int meson_reset_remove(struct platform_device *pdev) > +{ > + struct meson_reset_data *data = platform_get_drvdata(pdev); Don't you need to call platform_set_drvdata() in the probe() function for this to be valid? > + > + reset_controller_unregister(&data->rcdev); > + > + return 0; > +} > + > +static const struct of_device_id meson_reset_dt_ids[] = { > + { .compatible = "amlogic,meson6-rst-mgr-ao", }, > + { /* sentinel */ }, > +}; > + > +static struct platform_driver meson_reset_driver = { > + .probe = meson_reset_probe, > + .remove = meson_reset_remove, > + .driver = { > + .name = "meson-reset", > + .owner = THIS_MODULE, I believe you can drop the owner field. Beniamino
On Sun, Oct 12, 2014 at 6:03 PM, Beniamino Galvani <b.galvani@gmail.com> wrote: > Hi Carlo, Hi Beniamino, >> [...] >> + >> +static int meson_reset_probe(struct platform_device *pdev) >> +{ >> + struct meson_reset_data *data; >> + struct resource *res; >> + >> + /* >> + * The binding was mainlined without the required property. >> + * Do not continue, when we encounter an old DT. >> + */ >> + if (!of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) { >> + dev_err(&pdev->dev, "%s missing #reset-cells property\n", >> + pdev->dev.of_node->full_name); >> + return -EINVAL; >> + } > > Probably the above comment was taken from another driver but is not > relevant here. Right. Lazy copy and paste with brain off >> + >> +static int meson_reset_remove(struct platform_device *pdev) >> +{ >> + struct meson_reset_data *data = platform_get_drvdata(pdev); > > Don't you need to call platform_set_drvdata() in the probe() function > for this to be valid? Yes. Even though I believe the remove can never happen. >> + >> + reset_controller_unregister(&data->rcdev); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id meson_reset_dt_ids[] = { >> + { .compatible = "amlogic,meson6-rst-mgr-ao", }, >> + { /* sentinel */ }, >> +}; >> + >> +static struct platform_driver meson_reset_driver = { >> + .probe = meson_reset_probe, >> + .remove = meson_reset_remove, >> + .driver = { >> + .name = "meson-reset", >> + .owner = THIS_MODULE, > > I believe you can drop the owner field. I will. Thank you for your review,
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile index 60fed3d..74f2372 100644 --- a/drivers/reset/Makefile +++ b/drivers/reset/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RESET_CONTROLLER) += core.o obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o +obj-$(CONFIG_ARCH_MESON) += reset-meson.o obj-$(CONFIG_ARCH_STI) += sti/ diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c new file mode 100644 index 0000000..daeb604 --- /dev/null +++ b/drivers/reset/reset-meson.c @@ -0,0 +1,152 @@ +/* + * Copyright 2014 Carlo Caione <carlo@caione.org> + * + * based on + * Steffen Trumtrar Reset Controller driver + * + * Copyright 2014 Steffen Trumtrar + * + * Steffen Trumtrar <s.trumtrar@pengutronix.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + */ + +#include <linux/err.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/reset-controller.h> +#include <linux/spinlock.h> +#include <linux/types.h> + +#define MESON_RST_OFFSET 0x00 + +struct meson_reset_data { + spinlock_t lock; + void __iomem *membase; + struct reset_controller_dev rcdev; +}; + +static int meson_reset_assert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct meson_reset_data *data = container_of(rcdev, + struct meson_reset_data, + rcdev); + unsigned long flags; + u32 reg; + + spin_lock_irqsave(&data->lock, flags); + + reg = readl(data->membase + MESON_RST_OFFSET); + writel(reg | BIT(id), data->membase + MESON_RST_OFFSET); + + spin_unlock_irqrestore(&data->lock, flags); + + return 0; +} + +static int meson_reset_deassert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct meson_reset_data *data = container_of(rcdev, + struct meson_reset_data, + rcdev); + + unsigned long flags; + u32 reg; + + spin_lock_irqsave(&data->lock, flags); + + reg = readl(data->membase + MESON_RST_OFFSET); + writel(reg & ~BIT(id), data->membase + MESON_RST_OFFSET); + + spin_unlock_irqrestore(&data->lock, flags); + + return 0; +} + +static int meson_reset_dev(struct reset_controller_dev *rcdev, unsigned long id) +{ + int err; + + err = meson_reset_assert(rcdev, id); + if (err) + return err; + + return meson_reset_deassert(rcdev, id); +} + +static struct reset_control_ops meson_reset_ops = { + .assert = meson_reset_assert, + .deassert = meson_reset_deassert, + .reset = meson_reset_dev, +}; + +static int meson_reset_probe(struct platform_device *pdev) +{ + struct meson_reset_data *data; + struct resource *res; + + /* + * The binding was mainlined without the required property. + * Do not continue, when we encounter an old DT. + */ + if (!of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) { + dev_err(&pdev->dev, "%s missing #reset-cells property\n", + pdev->dev.of_node->full_name); + return -EINVAL; + } + + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + data->membase = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(data->membase)) + return PTR_ERR(data->membase); + + spin_lock_init(&data->lock); + + data->rcdev.owner = THIS_MODULE; + data->rcdev.nr_resets = BITS_PER_LONG; + data->rcdev.ops = &meson_reset_ops; + data->rcdev.of_node = pdev->dev.of_node; + reset_controller_register(&data->rcdev); + + return 0; +} + +static int meson_reset_remove(struct platform_device *pdev) +{ + struct meson_reset_data *data = platform_get_drvdata(pdev); + + reset_controller_unregister(&data->rcdev); + + return 0; +} + +static const struct of_device_id meson_reset_dt_ids[] = { + { .compatible = "amlogic,meson6-rst-mgr-ao", }, + { /* sentinel */ }, +}; + +static struct platform_driver meson_reset_driver = { + .probe = meson_reset_probe, + .remove = meson_reset_remove, + .driver = { + .name = "meson-reset", + .owner = THIS_MODULE, + .of_match_table = meson_reset_dt_ids, + }, +}; +module_platform_driver(meson_reset_driver); + +MODULE_AUTHOR("Carlo Caione <carlo@caione.org>"); +MODULE_DESCRIPTION("Meson Reset Controller Driver"); +MODULE_LICENSE("GPL");
This patch adds support for the reset controller found on the Amlogic MesonX SoCs. For several devices in the AO (Always-On) power domain, it is possible to reset them by programming a specific bit in a register. Signed-off-by: Carlo Caione <carlo@caione.org> --- drivers/reset/Makefile | 1 + drivers/reset/reset-meson.c | 152 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 153 insertions(+) create mode 100644 drivers/reset/reset-meson.c