| Message ID | 1413819079-17120-3-git-send-email-dinguyen@opensource.altera.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dinh, On Mon, Oct 20, 2014 at 8:31 AM, <dinguyen@opensource.altera.com> wrote: > +++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts > @@ -37,6 +37,15 @@ > */ > ethernet0 = &gmac1; > }; > + > + regulator_3_3v: regulator { I think it's better to give this a real node name. The "regulator_3_3v" will get dropped when you compile this into a binary format (for shipping), so you're creating a node that's just called "regulator". If you had more than one fixed regulator like this it just won't work. I haven't seen any official guidelines, but I tend to use "regulator" as a suffix and then put the schematic name. Like: 3_3v_regulator: 3-3-v-regulator > + compatible = "regulator-fixed"; > + regulator-name = "3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; It's probably not necessary to specify "boot-on" and "always-on" since there's no GPIO backing this (in other words, those properties are implied since there's no way to turn this regulator off). I haven't gone back and checked this against your schematics, but they look good to me. Once you've fixed above you are free to add my Reviewed-by if you wish. -Doug
On 10/20/2014 10:51 AM, Doug Anderson wrote: > Dinh, > > On Mon, Oct 20, 2014 at 8:31 AM, <dinguyen@opensource.altera.com> wrote: >> +++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts >> @@ -37,6 +37,15 @@ >> */ >> ethernet0 = &gmac1; >> }; >> + >> + regulator_3_3v: regulator { > > I think it's better to give this a real node name. The > "regulator_3_3v" will get dropped when you compile this into a binary > format (for shipping), so you're creating a node that's just called > "regulator". If you had more than one fixed regulator like this it > just won't work. > > I haven't seen any official guidelines, but I tend to use "regulator" > as a suffix and then put the schematic name. Like: > > 3_3v_regulator: 3-3-v-regulator > > Not sure if there's a limit on a node cannot start with numeric value? But if I change it to your suggestion, the DTC does not compile: Error: arch/arm/boot/dts/socfpga_cyclone5_socdk.dts:41.16-17 syntax error FATAL ERROR: Unable to parse input tree But regulator_3_3v: 3-3-v-regulator will work fine. Dinh
diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi b/arch/arm/boot/dts/socfpga_arria5.dtsi index 03e8268..1907cc6 100644 --- a/arch/arm/boot/dts/socfpga_arria5.dtsi +++ b/arch/arm/boot/dts/socfpga_arria5.dtsi @@ -29,7 +29,7 @@ }; }; - dwmmc0@ff704000 { + mmc0: dwmmc0@ff704000 { num-slots = <1>; broken-cd; bus-width = <4>; diff --git a/arch/arm/boot/dts/socfpga_arria5_socdk.dts b/arch/arm/boot/dts/socfpga_arria5_socdk.dts index 27d551c..1f64811 100644 --- a/arch/arm/boot/dts/socfpga_arria5_socdk.dts +++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts @@ -37,6 +37,15 @@ */ ethernet0 = &gmac1; }; + + regulator_3_3v: regulator { + compatible = "regulator-fixed"; + regulator-name = "3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; }; &gmac1 { @@ -68,6 +77,11 @@ }; }; +&mmc0 { + vmmc-supply = <®ulator_3_3v>; + vqmmc-supply = <®ulator_3_3v>; +}; + &usb1 { status = "okay"; }; diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts index 739c3b7..0f624a8 100644 --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts @@ -37,6 +37,15 @@ */ ethernet0 = &gmac1; }; + + regulator_3_3v: regulator { + compatible = "regulator-fixed"; + regulator-name = "3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; }; &gmac1 { @@ -70,6 +79,8 @@ &mmc0 { cd = <&gpio1 18 0>; + vmmc-supply = <®ulator_3_3v>; + vqmmc-supply = <®ulator_3_3v>; }; &usb1 { diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts index d26f155..3e0eff2 100644 --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts @@ -37,6 +37,15 @@ */ ethernet0 = &gmac1; }; + + regulator_3_3v: regulator { + compatible = "regulator-fixed"; + regulator-name = "VCC3P3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; }; &gmac1 { @@ -53,6 +62,11 @@ rxc-skew-ps = <2000>; }; +&mmc0 { + vmmc-supply = <®ulator_3_3v>; + vqmmc-supply = <®ulator_3_3v>; +}; + &usb1 { status = "okay"; };