From patchwork Wed Oct 22 19:07:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dinguyen@opensource.altera.com X-Patchwork-Id: 5136511 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 598939F30B for ; Wed, 22 Oct 2014 19:15:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3DB4220253 for ; Wed, 22 Oct 2014 19:15:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E6220145 for ; Wed, 22 Oct 2014 19:15:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xh1Kc-00080l-If; Wed, 22 Oct 2014 19:12:26 +0000 Received: from mail-by2on0063.outbound.protection.outlook.com ([207.46.100.63] helo=na01-by2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xh1K9-0007lZ-7J for linux-arm-kernel@lists.infradead.org; Wed, 22 Oct 2014 19:11:57 +0000 Received: from linux-builds1.altera.com (64.129.157.38) by CY1PR0301MB1194.namprd03.prod.outlook.com (25.160.165.25) with Microsoft SMTP Server (TLS) id 15.0.1054.13; Wed, 22 Oct 2014 19:11:35 +0000 From: To: , , , , , , Subject: [PATCHv4 2/3] ARM: dts: socfpga: Fix SD card detect Date: Wed, 22 Oct 2014 14:07:39 -0500 Message-ID: <1414004860-17645-3-git-send-email-dinguyen@opensource.altera.com> X-Mailer: git-send-email 2.0.3 In-Reply-To: <1414004860-17645-1-git-send-email-dinguyen@opensource.altera.com> References: <1414004860-17645-1-git-send-email-dinguyen@opensource.altera.com> MIME-Version: 1.0 X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR09CA0052.namprd09.prod.outlook.com (10.255.214.180) To CY1PR0301MB1194.namprd03.prod.outlook.com (25.160.165.25) X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1194; X-Forefront-PRVS: 037291602B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(76482002)(81156004)(53416004)(106356001)(19580395003)(99396003)(66066001)(104166001)(2201001)(92566001)(42186005)(86362001)(64706001)(62966002)(19580405001)(77096002)(20776003)(120916001)(77156001)(105586002)(229853001)(88136002)(107046002)(47776003)(50466002)(85852003)(87976001)(95666004)(102836001)(31966008)(97736003)(33646002)(76176999)(50986999)(40100003)(69596002)(122386002)(48376002)(101416001)(85306004)(87286001)(92726001)(50226001)(4396001)(93916002)(86152002)(21056001)(80022003)(89996001)(46102003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB1194; H:linux-builds1.altera.com; FPR:; MLV:sfv; PTR:InfoNoRecords; MX:1; A:0; LANG:en; X-OriginatorOrg: opensource.altera.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141022_121157_291695_B03F44D6 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.5 (/) Cc: devicetree@vger.kernel.org, dinh.linux@gmail.com, atull@opensource.altera.com, olof@lixom.net, Dinh Nguyen , s.trumtrar@pengutronix.de, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dinh Nguyen Without this patch, the booting the SOCFPGA platform would hang at the SDMMC driver loading. The issue, debugged by Doug Anderson, turned out to be that the GPIO bank used by the SD card-detect was not set to status="okay". Also update the cd-gpios to point to portb of the &gpio1 GPIO IP. Suggested-by: Doug Anderson Signed-off-by: Dinh Nguyen Reviewed-by: Doug Anderson --- v4: Use &gpio1 to set status="okay" and update cd-gpio=&portb v3: Correctly degugged the issue to be a gpio node not having status="okay" --- arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts index d7296a5..d91c943 100644 --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts @@ -53,6 +53,10 @@ rxc-skew-ps = <2000>; }; +&gpio1 { + status = "okay"; +}; + &i2c0 { status = "okay"; @@ -69,7 +73,7 @@ }; &mmc0 { - cd-gpios = <&gpio1 18 0>; + cd-gpios = <&portb 18 0>; }; &usb1 {