| Message ID | 1415539714-7652-2-git-send-email-merker@debian.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 11/09/2014 02:28 PM, Karsten Merker wrote: > On the LeMaker Banana Pi, probing the external ethernet PHY connected > to the SoC's internal GMAC module sometimes fails. The PHY power > supply is handled via a GPIO-controlled regulator, and the existing > regulator startup-delay of 50000us is too short to make sure that the > PHY is always fully powered up when it is queried by phylib. To > guarantee a reliable PHY detection, the startup-delay has to be > increased to 60000us. We should probably just increase it to 100000us to be safe, otherwise: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans
On Sun, Nov 09, 2014 at 10:05:26PM +0100, Hans de Goede wrote: > Hi, > > On 11/09/2014 02:28 PM, Karsten Merker wrote: > > On the LeMaker Banana Pi, probing the external ethernet PHY connected > > to the SoC's internal GMAC module sometimes fails. The PHY power > > supply is handled via a GPIO-controlled regulator, and the existing > > regulator startup-delay of 50000us is too short to make sure that the > > PHY is always fully powered up when it is queried by phylib. To > > guarantee a reliable PHY detection, the startup-delay has to be > > increased to 60000us. > > We should probably just increase it to 100000us to be safe, otherwise: > > Acked-by: Hans de Goede <hdegoede@redhat.com> Soooo, should I merge it or will there be a v2? Maxime
Hi, On 11/11/2014 06:34 PM, Maxime Ripard wrote: > On Sun, Nov 09, 2014 at 10:05:26PM +0100, Hans de Goede wrote: >> Hi, >> >> On 11/09/2014 02:28 PM, Karsten Merker wrote: >>> On the LeMaker Banana Pi, probing the external ethernet PHY connected >>> to the SoC's internal GMAC module sometimes fails. The PHY power >>> supply is handled via a GPIO-controlled regulator, and the existing >>> regulator startup-delay of 50000us is too short to make sure that the >>> PHY is always fully powered up when it is queried by phylib. To >>> guarantee a reliable PHY detection, the startup-delay has to be >>> increased to 60000us. >> >> We should probably just increase it to 100000us to be safe, otherwise: >> >> Acked-by: Hans de Goede <hdegoede@redhat.com> > > Soooo, should I merge it or will there be a v2? It might be easiest if you merge it with the delay increased to 100000 us, assuming you agree that it is a good idea to add some extra safety margin. Regards, Hans
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 3de847d..36065d1 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts @@ -207,7 +207,7 @@ regulator-name = "gmac-3v3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; - startup-delay-us = <50000>; + startup-delay-us = <60000>; enable-active-high; gpio = <&pio 7 23 0>; };
On the LeMaker Banana Pi, probing the external ethernet PHY connected to the SoC's internal GMAC module sometimes fails. The PHY power supply is handled via a GPIO-controlled regulator, and the existing regulator startup-delay of 50000us is too short to make sure that the PHY is always fully powered up when it is queried by phylib. To guarantee a reliable PHY detection, the startup-delay has to be increased to 60000us. Signed-off-by: Karsten Merker <merker@debian.org> --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)