| Message ID | 1416236863-20898-2-git-send-email-dbaryshkov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 17, 2014 at 06:07:40PM +0300, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > --- > drivers/i2c/busses/i2c-pxa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index be671f7..2e75375 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -1297,7 +1297,7 @@ static int i2c_pxa_suspend_noirq(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct pxa_i2c *i2c = platform_get_drvdata(pdev); > > - clk_disable(i2c->clk); > + clk_disable_unprepare(i2c->clk); Since clk_unprepare() and clk_prepare() can sleep, it is unwise to call these with IRQs disabled - the _noirq variants of these are run with IRQs disabled.
On Mon, Nov 17, 2014 at 06:07:40PM +0300, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). You describe what is done but we can see that from the patch. Please describe here why the change is needed. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > --- > drivers/i2c/busses/i2c-pxa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index be671f7..2e75375 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -1297,7 +1297,7 @@ static int i2c_pxa_suspend_noirq(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct pxa_i2c *i2c = platform_get_drvdata(pdev); > > - clk_disable(i2c->clk); > + clk_disable_unprepare(i2c->clk); > > return 0; > } > @@ -1307,7 +1307,7 @@ static int i2c_pxa_resume_noirq(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct pxa_i2c *i2c = platform_get_drvdata(pdev); > > - clk_enable(i2c->clk); > + clk_prepare_enable(i2c->clk); > i2c_pxa_reset(i2c); > > return 0; > -- > 2.1.1 >
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index be671f7..2e75375 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1297,7 +1297,7 @@ static int i2c_pxa_suspend_noirq(struct device *dev) struct platform_device *pdev = to_platform_device(dev); struct pxa_i2c *i2c = platform_get_drvdata(pdev); - clk_disable(i2c->clk); + clk_disable_unprepare(i2c->clk); return 0; } @@ -1307,7 +1307,7 @@ static int i2c_pxa_resume_noirq(struct device *dev) struct platform_device *pdev = to_platform_device(dev); struct pxa_i2c *i2c = platform_get_drvdata(pdev); - clk_enable(i2c->clk); + clk_prepare_enable(i2c->clk); i2c_pxa_reset(i2c); return 0;
Change clk_enable/disable() calls to clk_prepare_enable() and clk_disable_unprepare(). Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- drivers/i2c/busses/i2c-pxa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)