From patchwork Tue Nov 18 19:10:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baker X-Patchwork-Id: 5332751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A7D3C9F2ED for ; Tue, 18 Nov 2014 19:13:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DCD9420160 for ; Tue, 18 Nov 2014 19:13:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F849200DB for ; Tue, 18 Nov 2014 19:13:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XqoC8-0001Na-SU; Tue, 18 Nov 2014 19:12:08 +0000 Received: from mail-pa0-f50.google.com ([209.85.220.50]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XqoBw-0001Ep-9e for linux-arm-kernel@lists.infradead.org; Tue, 18 Nov 2014 19:11:57 +0000 Received: by mail-pa0-f50.google.com with SMTP id bj1so4873347pad.23 for ; Tue, 18 Nov 2014 11:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zWH7PaQ04lCO+BO5OAwbR9ZAo9rnvDggSaFXBwxm9Zk=; b=HijQ65WeiteNUCTYWzU0tS1jxW8KSGsmr1+shHMVVvFKmA4UIAY9kFwqIfbV8y6pZb NyZgarcV1w3YrHGNN7EB46xaatgW0dDEXjnGDIIYtsu/Cxqa4b0oHqiXWF6QOtzfNw8O DsgU7WmyMPlqFjvzFNTmPtTAbBshlYabPdj4DqHQHSeUD29HQwiWXAjyjwztHAedKiyv PUydj2ln226nNqULKWU33L+j+etzMsY/Q9P6gGRu0Lvye5fUiO5L/iNeaegMYEsK5GBK KVY3dYoK4QrAUD2iAWfU6SdTeSzcGidQFxlH5NYydIgqbb2UCMlAnSimackq+Vgc271a Se8A== X-Gm-Message-State: ALoCoQmNZRFK/N569FGe+isGnY/vL/W79rdlJNYFQxKLeHhXNrq1ZlyFMD44u/xxGluCutjqRcRm X-Received: by 10.70.32.197 with SMTP id l5mr29208096pdi.67.1416337885183; Tue, 18 Nov 2014 11:11:25 -0800 (PST) Received: from localhost.localdomain ([173.14.250.228]) by mx.google.com with ESMTPSA id zn2sm38561414pbb.41.2014.11.18.11.11.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Nov 2014 11:11:24 -0800 (PST) From: Tyler Baker To: linux-arm-kernel@lists.infradead.org, arm@kernel.org Subject: [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller Date: Tue, 18 Nov 2014 11:10:53 -0800 Message-Id: <1416337853-1558-1-git-send-email-tyler.baker@linaro.org> X-Mailer: git-send-email 2.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141118_111156_392154_F2033255 X-CRM114-Status: GOOD ( 10.57 ) X-Spam-Score: -0.7 (/) Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, Tyler Baker X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes a long standing issue introduced during the 3.16 merge window. Shortly after the merge, exynos5250-based arndale boards began to produce the following errors: kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22 Further analysis revealed that the S5M8767 voltage regulator used on the exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator fails to probe. Therefore a dependency exists between these two drivers. In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410 options are enabled, and no errors are produced. However, in the multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the multi_v7_defconfig to allow the S5M8767 voltage regulator to probe. Signed-off-by: Tyler Baker Acked-by: Kukjin Kim --- This issue was reported [1]. I've also confirmed this fix on two different arndale boards. [1] https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg38765.html arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 3487046..9d7a32f 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -217,6 +217,7 @@ CONFIG_I2C_CADENCE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_EXYNOS5=y CONFIG_I2C_MV64XXX=y +CONFIG_I2C_S3C2410=y CONFIG_I2C_SIRF=y CONFIG_I2C_TEGRA=y CONFIG_I2C_ST=y