diff mbox

[2/2] MAINTAINERS: ARM Versatile Express platform

Message ID 1416939455-1814-2-git-send-email-pawel.moll@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Pawel Moll Nov. 25, 2014, 6:17 p.m. UTC
This patch adds a separate section for the ARM
Versatile Express platform maintainers, listing
all different bits and bobs used by it.

Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 MAINTAINERS | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Mike Turquette Nov. 26, 2014, 1:54 a.m. UTC | #1
Quoting Pawel Moll (2014-11-25 10:17:35)
> This patch adds a separate section for the ARM
> Versatile Express platform maintainers, listing
> all different bits and bobs used by it.
> 
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

Acked-by: Michael Turquette <mturquette@linaro.org>

> ---
>  MAINTAINERS | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0ff630d..e0cb002 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1503,6 +1503,25 @@ S:       Maintained
>  F:     drivers/clk/ux500/
>  F:     include/linux/platform_data/clk-ux500.h
>  
> +ARM/VERSATILE EXPRESS PLATFORM
> +M:     Liviu Dudau <liviu.dudau@arm.com>
> +M:     Sudeep Holla <sudeep.holla@arm.com>
> +M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> +L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> +S:     Maintained
> +F:     arch/arm/boot/dts/vexpress-*
> +F:     arch/arm/mach-vexpress/*
> +F:     drivers/bus/vexpress-config.c
> +F:     drivers/clk/versatile/clk-vexpress-osc.c
> +F:     drivers/clocksource/versatile.c
> +F:     drivers/cpufreq/vexpress-spc-cpufreq.c
> +F:     drivers/hwmon/vexpress.c
> +F:     drivers/mfd/vexpress-sysreg.c
> +F:     drivers/misc/vexpress-vexpress-syscfg.c
> +F:     drivers/power/reset/vexpress-poweroff.c
> +F:     drivers/regulator/vexpress.c
> +F:     include/linux/vexpress.h
> +
>  ARM/VFP SUPPORT
>  M:     Russell King <linux@arm.linux.org.uk>
>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -- 
> 2.1.0
>
Joe Perches Nov. 26, 2014, 1:59 a.m. UTC | #2
On Tue, 2014-11-25 at 17:54 -0800, Mike Turquette wrote:
> Quoting Pawel Moll (2014-11-25 10:17:35)
> > This patch adds a separate section for the ARM
> > Versatile Express platform maintainers, listing
> > all different bits and bobs used by it.
[]
> > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > +ARM/VERSATILE EXPRESS PLATFORM
[]
> > +F:     arch/arm/boot/dts/vexpress-*
> > +F:     arch/arm/mach-vexpress/*
> > +F:     drivers/bus/vexpress-config.c
> > +F:     drivers/clk/versatile/clk-vexpress-osc.c
> > +F:     drivers/clocksource/versatile.c
> > +F:     drivers/cpufreq/vexpress-spc-cpufreq.c
> > +F:     drivers/hwmon/vexpress.c
> > +F:     drivers/mfd/vexpress-sysreg.c
> > +F:     drivers/misc/vexpress-vexpress-syscfg.c
> > +F:     drivers/power/reset/vexpress-poweroff.c
> > +F:     drivers/regulator/vexpress.c
> > +F:     include/linux/vexpress.h
> >

maybe
F:	arch/arm/boot/dts/vexpress*
F:	arch/arm/mach-vexpress/
F:	*/*/vexpress*
F:	*/*/*/*vexpress*
F:	drivers/clocksource/versatile.c
Pawel Moll Nov. 26, 2014, 12:04 p.m. UTC | #3
On Wed, 2014-11-26 at 01:59 +0000, Joe Perches wrote:
> On Tue, 2014-11-25 at 17:54 -0800, Mike Turquette wrote:
> > Quoting Pawel Moll (2014-11-25 10:17:35)
> > > This patch adds a separate section for the ARM
> > > Versatile Express platform maintainers, listing
> > > all different bits and bobs used by it.
> []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > > +ARM/VERSATILE EXPRESS PLATFORM
> []
> > > +F:     arch/arm/boot/dts/vexpress-*
> > > +F:     arch/arm/mach-vexpress/*
> > > +F:     drivers/bus/vexpress-config.c
> > > +F:     drivers/clk/versatile/clk-vexpress-osc.c
> > > +F:     drivers/clocksource/versatile.c
> > > +F:     drivers/cpufreq/vexpress-spc-cpufreq.c
> > > +F:     drivers/hwmon/vexpress.c
> > > +F:     drivers/mfd/vexpress-sysreg.c
> > > +F:     drivers/misc/vexpress-vexpress-syscfg.c
> > > +F:     drivers/power/reset/vexpress-poweroff.c
> > > +F:     drivers/regulator/vexpress.c
> > > +F:     include/linux/vexpress.h
> > >
> 
> maybe
> F:	arch/arm/boot/dts/vexpress*

Ok.

> F:	arch/arm/mach-vexpress/

Right, of course. Whole directory.

> F:	*/*/vexpress*

Cool, didn't think about multiple wildcards. 

> F:	*/*/*/*vexpress*

I'd keep the clk-vexpress-osc.c explicit - it's an odd one, and don't
feel comfortable with the wildcard before vexpress.

> F:	drivers/clocksource/versatile.c

Thanks for the suggestion, sill spin the patch in a second.

Pawel
Arnd Bergmann Nov. 26, 2014, 12:17 p.m. UTC | #4
On Wednesday 26 November 2014 12:04:09 Pawel Moll wrote:
> 
> Right, of course. Whole directory.
> 
> > F:    */*/vexpress*
> 
> Cool, didn't think about multiple wildcards. 

Actually, I think you could even do this as

N:	vexpress

which would be even shorter and match most of the other entries too.

	Arnd
Pawel Moll Nov. 26, 2014, 2:40 p.m. UTC | #5
On Wed, 2014-11-26 at 12:17 +0000, Arnd Bergmann wrote:
> On Wednesday 26 November 2014 12:04:09 Pawel Moll wrote:
> > 
> > Right, of course. Whole directory.
> > 
> > > F:    */*/vexpress*
> > 
> > Cool, didn't think about multiple wildcards. 
> 
> Actually, I think you could even do this as
> 
> N:	vexpress
> 
> which would be even shorter and match most of the other entries too.

If you think it's safe, fine with me. It would reduce this section to:

N:	vexpress
F:	drivers/clocksource/versatile.c

I'll spin the patch again.

Pawel
Joe Perches Nov. 26, 2014, 3:40 p.m. UTC | #6
On Wed, 2014-11-26 at 14:40 +0000, Pawel Moll wrote:
> On Wed, 2014-11-26 at 12:17 +0000, Arnd Bergmann wrote:
> > On Wednesday 26 November 2014 12:04:09 Pawel Moll wrote:
> > > 
> > > Right, of course. Whole directory.
> > > 
> > > > F:    */*/vexpress*
> > > 
> > > Cool, didn't think about multiple wildcards. 
> > 
> > Actually, I think you could even do this as
> > 
> > N:	vexpress
> > 
> > which would be even shorter and match most of the other entries too.
> 
> If you think it's safe, fine with me. It would reduce this section to:
> 
> N:	vexpress
> F:	drivers/clocksource/versatile.c

Yes, that's possible too, but:

from MAINTAINERS:

	   scripts/get_maintainer.pl has different behavior for files that
	   match F: pattern and matches of N: patterns.  By default,
	   get_maintainer will not look at git log history when an F: pattern
	   match occurs.  When an N: match occurs, git log history is used
	   to also notify the people that have git commit signatures.

I think it's better to use F: entries because
there is a get_maintainer difference in behavior
between N: and F: entries.

An N: entry means get_maintainer will also cc
patch submitters for these files.

An F: entry will not.
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 0ff630d..e0cb002 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1503,6 +1503,25 @@  S:	Maintained
 F:	drivers/clk/ux500/
 F:	include/linux/platform_data/clk-ux500.h
 
+ARM/VERSATILE EXPRESS PLATFORM
+M:	Liviu Dudau <liviu.dudau@arm.com>
+M:	Sudeep Holla <sudeep.holla@arm.com>
+M:	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
+S:	Maintained
+F:	arch/arm/boot/dts/vexpress-*
+F:	arch/arm/mach-vexpress/*
+F:	drivers/bus/vexpress-config.c
+F:	drivers/clk/versatile/clk-vexpress-osc.c
+F:	drivers/clocksource/versatile.c
+F:	drivers/cpufreq/vexpress-spc-cpufreq.c
+F:	drivers/hwmon/vexpress.c
+F:	drivers/mfd/vexpress-sysreg.c
+F:	drivers/misc/vexpress-vexpress-syscfg.c
+F:	drivers/power/reset/vexpress-poweroff.c
+F:	drivers/regulator/vexpress.c
+F:	include/linux/vexpress.h
+
 ARM/VFP SUPPORT
 M:	Russell King <linux@arm.linux.org.uk>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)