| Message ID | 1417502073-6322-1-git-send-email-a.kesavan@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Tuesday, December 02, 2014 12:04:32 PM Abhilash Kesavan wrote: > As samsung thermal support is enabled only for ARCH_EXYNOS, there is no > need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this > dependency will also allow the driver to be enabled on 64-bit SoCs. > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > --- > This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for > arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > drivers/thermal/samsung/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig > index f760389..c43306e 100644 > --- a/drivers/thermal/samsung/Kconfig > +++ b/drivers/thermal/samsung/Kconfig > @@ -1,6 +1,6 @@ > config EXYNOS_THERMAL > tristate "Exynos thermal management unit driver" > - depends on ARCH_HAS_BANDGAP && OF > + depends on OF > help > If you say yes here you get support for the TMU (Thermal Management > Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
Hi Abhilash, > As samsung thermal support is enabled only for ARCH_EXYNOS, there is > no need to select ARCH_HAS_BANDGAP from the arch-specific code. > Removing this dependency will also allow the driver to be enabled on > 64-bit SoCs. > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > --- > This was based on the discussion regarding adding ARCH_HAS_BANDGAP > symbol for arm64 here: > http://www.spinics.net/lists/arm-kernel/msg377560.html > > drivers/thermal/samsung/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/Kconfig > b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644 > --- a/drivers/thermal/samsung/Kconfig > +++ b/drivers/thermal/samsung/Kconfig > @@ -1,6 +1,6 @@ > config EXYNOS_THERMAL > tristate "Exynos thermal management unit driver" > - depends on ARCH_HAS_BANDGAP && OF > + depends on OF > help > If you say yes here you get support for the TMU (Thermal > Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This > driver initialises Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Hi Eduardo, On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Hi Abhilash, > >> As samsung thermal support is enabled only for ARCH_EXYNOS, there is >> no need to select ARCH_HAS_BANDGAP from the arch-specific code. >> Removing this dependency will also allow the driver to be enabled on >> 64-bit SoCs. >> >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> >> --- >> This was based on the discussion regarding adding ARCH_HAS_BANDGAP >> symbol for arm64 here: >> http://www.spinics.net/lists/arm-kernel/msg377560.html >> >> drivers/thermal/samsung/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/samsung/Kconfig >> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644 >> --- a/drivers/thermal/samsung/Kconfig >> +++ b/drivers/thermal/samsung/Kconfig >> @@ -1,6 +1,6 @@ >> config EXYNOS_THERMAL >> tristate "Exynos thermal management unit driver" >> - depends on ARCH_HAS_BANDGAP && OF >> + depends on OF >> help >> If you say yes here you get support for the TMU (Thermal >> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This >> driver initialises > > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> Can you pick up these 2 patches if they look OK ? Regards, Abhilash > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
On Wed, Dec 10, 2014 at 09:26:55AM +0530, Abhilash Kesavan wrote: > Hi Eduardo, > > On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote: > > Hi Abhilash, > > > >> As samsung thermal support is enabled only for ARCH_EXYNOS, there is > >> no need to select ARCH_HAS_BANDGAP from the arch-specific code. > >> Removing this dependency will also allow the driver to be enabled on > >> 64-bit SoCs. > >> > >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > >> --- > >> This was based on the discussion regarding adding ARCH_HAS_BANDGAP > >> symbol for arm64 here: > >> http://www.spinics.net/lists/arm-kernel/msg377560.html > >> > >> drivers/thermal/samsung/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/thermal/samsung/Kconfig > >> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644 > >> --- a/drivers/thermal/samsung/Kconfig > >> +++ b/drivers/thermal/samsung/Kconfig > >> @@ -1,6 +1,6 @@ > >> config EXYNOS_THERMAL > >> tristate "Exynos thermal management unit driver" > >> - depends on ARCH_HAS_BANDGAP && OF > >> + depends on OF > >> help > >> If you say yes here you get support for the TMU (Thermal > >> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This > >> driver initialises > > > > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> > > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > > Can you pick up these 2 patches if they look OK ? OK. Adding to my fixes queue. > > Regards, > Abhilash > > > > -- > > Best regards, > > > > Lukasz Majewski > > > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644 --- a/drivers/thermal/samsung/Kconfig +++ b/drivers/thermal/samsung/Kconfig @@ -1,6 +1,6 @@ config EXYNOS_THERMAL tristate "Exynos thermal management unit driver" - depends on ARCH_HAS_BANDGAP && OF + depends on OF help If you say yes here you get support for the TMU (Thermal Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs. Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> --- This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html drivers/thermal/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)