| Message ID | 1417691402-28166-1-git-send-email-dbaryshkov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes: > Add regulator_has_full_constraints() call to corgi board file to let > regulator core know that we do not have any additional regulators left. > This lets it substitute unprovided regulators with dummy ones. > > This fixes the following warnings that can be seen on corgi if > regulators are enabled: > > ads7846 spi1.0: unable to get regulator: -517 > spi spi1.0: Driver ads7846 requests probe deferral > wm8731 0-001b: Failed to get supply 'AVDD': -517 > wm8731 0-001b: Failed to request supplies: -517 > wm8731 0-001b: ASoC: failed to probe component -517 > corgi-audio corgi-audio: ASoC: failed to instantiate card -517 > > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > --- > arch/arm/mach-pxa/corgi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c > index 06022b2..89f790d 100644 > --- a/arch/arm/mach-pxa/corgi.c > +++ b/arch/arm/mach-pxa/corgi.c > @@ -26,6 +26,7 @@ > #include <linux/i2c.h> > #include <linux/i2c/pxa-i2c.h> > #include <linux/io.h> > +#include <linux/regulator/machine.h> > #include <linux/spi/spi.h> > #include <linux/spi/ads7846.h> > #include <linux/spi/corgi_lcd.h> > @@ -752,6 +753,8 @@ static void __init corgi_init(void) > sharpsl_nand_partitions[1].size = 53 * 1024 * 1024; > > platform_add_devices(devices, ARRAY_SIZE(devices)); > + > + regulator_has_full_constraints(); > } > > static void __init fixup_corgi(struct tag *tags, char **cmdline) Added Mark for review, as I was thinking regulator_has_full_constraints() was to be used to disable unused regulators, a bit like in the clock framework, rather than provide a way to provide automatically dummy regulators. If Mark acks, I'll take the serie.
On Thu, Dec 04, 2014 at 09:41:45PM +0100, Robert Jarzmik wrote: > Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes: > > + regulator_has_full_constraints(); > Added Mark for review, as I was thinking regulator_has_full_constraints() was to > be used to disable unused regulators, a bit like in the clock framework, rather > than provide a way to provide automatically dummy regulators. > If Mark acks, I'll take the serie. It's both, it's telling the core that the board has told it about all the regulator mappings it's ever going to tell it about.
Mark Brown <broonie@kernel.org> writes: > On Thu, Dec 04, 2014 at 09:41:45PM +0100, Robert Jarzmik wrote: >> Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes: > >> > + regulator_has_full_constraints(); > >> Added Mark for review, as I was thinking regulator_has_full_constraints() was to >> be used to disable unused regulators, a bit like in the clock framework, rather >> than provide a way to provide automatically dummy regulators. > >> If Mark acks, I'll take the serie. > > It's both, it's telling the core that the board has told it about all > the regulator mappings it's ever going to tell it about. OK, I'll take that as an Acked-by then. Cheers.
Robert Jarzmik <robert.jarzmik@free.fr> writes: > Mark Brown <broonie@kernel.org> writes: > OK, I'll take that as an Acked-by then. Queued the 3 of them in pxa/for-next, thanks. Cheers.
diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c index 06022b2..89f790d 100644 --- a/arch/arm/mach-pxa/corgi.c +++ b/arch/arm/mach-pxa/corgi.c @@ -26,6 +26,7 @@ #include <linux/i2c.h> #include <linux/i2c/pxa-i2c.h> #include <linux/io.h> +#include <linux/regulator/machine.h> #include <linux/spi/spi.h> #include <linux/spi/ads7846.h> #include <linux/spi/corgi_lcd.h> @@ -752,6 +753,8 @@ static void __init corgi_init(void) sharpsl_nand_partitions[1].size = 53 * 1024 * 1024; platform_add_devices(devices, ARRAY_SIZE(devices)); + + regulator_has_full_constraints(); } static void __init fixup_corgi(struct tag *tags, char **cmdline)
Add regulator_has_full_constraints() call to corgi board file to let regulator core know that we do not have any additional regulators left. This lets it substitute unprovided regulators with dummy ones. This fixes the following warnings that can be seen on corgi if regulators are enabled: ads7846 spi1.0: unable to get regulator: -517 spi spi1.0: Driver ads7846 requests probe deferral wm8731 0-001b: Failed to get supply 'AVDD': -517 wm8731 0-001b: Failed to request supplies: -517 wm8731 0-001b: ASoC: failed to probe component -517 corgi-audio corgi-audio: ASoC: failed to instantiate card -517 Cc: stable@vger.kernel.org Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- arch/arm/mach-pxa/corgi.c | 3 +++ 1 file changed, 3 insertions(+)