diff mbox

[v2,2/2] ARM: mediatek: dts: Add bindings for watchdog

Message ID 1418395859-32209-3-git-send-email-matthias.bgg@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Matthias Brugger Dec. 12, 2014, 2:50 p.m. UTC 
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

Comments

Guenter Roeck Dec. 13, 2014, 3:45 p.m. UTC | #1 
On 12/12/2014 06:50 AM, Matthias Brugger wrote:
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> new file mode 100644
> index 0000000..af9eb5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -0,0 +1,13 @@
> +Mediatek SoCs Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "mediatek,mt6589-wdt"

"mediatek" is undefined as vendor prefix in the current upstream code.
Is this vendor prefix coming in from another patch set ?

Guenter

> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +wdt: watchdog@010000000 {
> +	compatible = "mediatek,mt6589-wdt";
> +	reg = <0x10000000 0x18>;
> +};
>
Matthias Brugger Dec. 16, 2014, 4:14 p.m. UTC | #2 
2014-12-13 16:45 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
> On 12/12/2014 06:50 AM, Matthias Brugger wrote:
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 13
>> +++++++++++++
>>   1 file changed, 13 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> new file mode 100644
>> index 0000000..af9eb5b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> @@ -0,0 +1,13 @@
>> +Mediatek SoCs Watchdog timer
>> +
>> +Required properties:
>> +
>> +- compatible : should be "mediatek,mt6589-wdt"
>
>
> "mediatek" is undefined as vendor prefix in the current upstream code.
> Is this vendor prefix coming in from another patch set ?

Strange, should be in vendor-prefix.txt [1].
Please double check.

Thanks,
Matthias

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/vendor-prefixes.txt?id=refs/tags/v3.18#n93

>
> Guenter
>
>
>> +- reg : Specifies base physical address and size of the registers.
>> +
>> +Example:
>> +
>> +wdt: watchdog@010000000 {
>> +       compatible = "mediatek,mt6589-wdt";
>> +       reg = <0x10000000 0x18>;
>> +};
>>
>
Guenter Roeck Dec. 16, 2014, 4:34 p.m. UTC | #3 
On Tue, Dec 16, 2014 at 05:14:35PM +0100, Matthias Brugger wrote:
> 2014-12-13 16:45 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
> > On 12/12/2014 06:50 AM, Matthias Brugger wrote:
> >>
> >> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> ---
> >>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 13
> >> +++++++++++++
> >>   1 file changed, 13 insertions(+)
> >>   create mode 100644
> >> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> >> b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> >> new file mode 100644
> >> index 0000000..af9eb5b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> >> @@ -0,0 +1,13 @@
> >> +Mediatek SoCs Watchdog timer
> >> +
> >> +Required properties:
> >> +
> >> +- compatible : should be "mediatek,mt6589-wdt"
> >
> >
> > "mediatek" is undefined as vendor prefix in the current upstream code.
> > Is this vendor prefix coming in from another patch set ?
> 
> Strange, should be in vendor-prefix.txt [1].
> Please double check.
> 
Sorry, I misunderstood the output from checkpatch.

Guenter
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
new file mode 100644
index 0000000..af9eb5b
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -0,0 +1,13 @@ 
+Mediatek SoCs Watchdog timer
+
+Required properties:
+
+- compatible : should be "mediatek,mt6589-wdt"
+- reg : Specifies base physical address and size of the registers.
+
+Example:
+
+wdt: watchdog@010000000 {
+	compatible = "mediatek,mt6589-wdt";
+	reg = <0x10000000 0x18>;
+};