| Message ID | 1421372666-12288-24-git-send-email-wangyijing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 1/16/2015 4:44 AM, Yijing Wang wrote: > Use pci_scan_root_bus() instead of pci_create_root_bus() + > pci_scan_child_bus() for simplicity. > Signed-off-by: Yijing Wang <wangyijing@huawei.com> > --- > drivers/pci/host/pcie-designware.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index eef3111..d37fe27 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) > struct pcie_port *pp = sys_to_pcie(sys); > > pp->root_bus_nr = sys->busnr; > - bus = pci_create_root_bus(pp->dev, sys->busnr, > + bus = pci_scan_root_bus(pp->dev, sys->busnr, > &dw_pcie_ops, sys, &sys->resources); Please realign this line, so that it still starts under 'pp'. WBR, Sergei
On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . >
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index eef3111..d37fe27 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) struct pcie_port *pp = sys_to_pcie(sys); pp->root_bus_nr = sys->busnr; - bus = pci_create_root_bus(pp->dev, sys->busnr, + bus = pci_scan_root_bus(pp->dev, sys->busnr, &dw_pcie_ops, sys, &sys->resources); if (!bus) return NULL; - pci_scan_child_bus(bus); - if (bus && pp->ops->scan_bus) pp->ops->scan_bus(pp);
Use pci_scan_root_bus() instead of pci_create_root_bus() + pci_scan_child_bus() for simplicity. Signed-off-by: Yijing Wang <wangyijing@huawei.com> --- drivers/pci/host/pcie-designware.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)