From patchwork Tue Jan 27 01:45:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 5714101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E7D08C058D for ; Tue, 27 Jan 2015 01:47:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F031220160 for ; Tue, 27 Jan 2015 01:47:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37DF42015A for ; Tue, 27 Jan 2015 01:47:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YFvEC-00045v-PT; Tue, 27 Jan 2015 01:46:04 +0000 Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YFvE8-00044L-L3 for linux-arm-kernel@lists.infradead.org; Tue, 27 Jan 2015 01:46:01 +0000 Received: by mail-oi0-f49.google.com with SMTP id a3so10206822oib.8 for ; Mon, 26 Jan 2015 17:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=riXQFSPL0B16t60ZZwtVObBr1zXwbOFswjAuoRez7aw=; b=zB8YSjvIZcZDBzZ+7jqnFdezdvqeaeeirmp5kQ0jt2Ic4GZOlV6XlTMxqZoJbUxISZ ZXGiFTzeEAloNsWWftFM101U7n1nfahxS8UnEDkjB4bQ3CFqSDw+qmmZ/3mlhPeszI+p Fi7VYB9lKAoqgwRrgiBzxWwDGVeqO5bi9tKvyzjhr2w8HcZPhPY6Z4DkR+QMDoN0XZD6 SoU0Y2cNMoOUpGqI67fjoYMe6LWVshF0KI7LSmsq5tSpwWdNFrw5RgMv5qr/UtHFsw+I uute/WW+zR1uveatwNV99yNfnIF1uk/+A37JLKtDoO3vvGBF+qVjErjSnhAKPNbMBNWC zppw== X-Received: by 10.202.88.132 with SMTP id m126mr13764905oib.57.1422323139380; Mon, 26 Jan 2015 17:45:39 -0800 (PST) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id i131sm6192806oib.9.2015.01.26.17.45.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 17:45:38 -0800 (PST) From: Soren Brinkmann To: =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [PATCH] usb: phy-generic: Don't fail on missing gpio reset Date: Mon, 26 Jan 2015 17:45:29 -0800 Message-Id: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.2.2.1.g63c5777 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150126_174600_745958_10EB47DF X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) Cc: devicetree@vger.kernel.org, Peter Crosthwaite , Ola Jeppson , Arnd Bergmann , linux-usb@vger.kernel.org, Michal Simek , Felipe Balbi , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Soren Brinkmann , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas Färber Signed-off-by: Soren Brinkmann --- Hi Andreas, does this do the trick? Thanks, Sören drivers/usb/phy/phy-generic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index dd05254241fb..a73d4c738f0b 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop, if (err == -EPROBE_DEFER) return -EPROBE_DEFER; - if (err) { - dev_err(dev, "Error requesting RESET GPIO\n"); - return err; - } + if (err) + nop->gpiod_reset = NULL; nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg), GFP_KERNEL);