| Message ID | 1423992723-5028-3-git-send-email-wuyun.wu@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 15 Feb 2015 09:31:59 +0000 Yun Wu <wuyun.wu@huawei.com> wrote: > The field of page size in register GITS_BASERn might be read-only > if an implementation only supports a single, fixed page size. But > currently the ITS driver will throw out an error when PAGE_SIZE > is less than the minimum size supported by an ITS. So addressing > this problem by using 64KB pages as default granule for all the > ITS base tables. > > Signed-off-by: Yun Wu <wuyun.wu@huawei.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c > b/drivers/irqchip/irq-gic-v3-its.c index 69eeea3..f5bfa42 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -800,7 +800,7 @@ static int its_alloc_tables(struct its_node *its) > { > int err; > int i; > - int psz = PAGE_SIZE; > + int psz = SZ_64K; > u64 shr = GITS_BASER_InnerShareable; > > for (i = 0; i < GITS_BASER_NR_REGS; i++) { > -- > 1.8.0 > > >
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 69eeea3..f5bfa42 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -800,7 +800,7 @@ static int its_alloc_tables(struct its_node *its) { int err; int i; - int psz = PAGE_SIZE; + int psz = SZ_64K; u64 shr = GITS_BASER_InnerShareable; for (i = 0; i < GITS_BASER_NR_REGS; i++) {
The field of page size in register GITS_BASERn might be read-only if an implementation only supports a single, fixed page size. But currently the ITS driver will throw out an error when PAGE_SIZE is less than the minimum size supported by an ITS. So addressing this problem by using 64KB pages as default granule for all the ITS base tables. Signed-off-by: Yun Wu <wuyun.wu@huawei.com> --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.0