diff mbox

[06/12] ARM: DT: apq8064: add pci support in CM QS600

Message ID 1424678135-13178-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Srinivas Kandagatla Feb. 23, 2015, 7:55 a.m. UTC 
From: Nicolas Dechesne <nicolas.dechesne@linaro.org>

This patch adds PCIE support to APQ8064, tested with Ethernet on Compulab QS600 board.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Igor Grinberg Feb. 23, 2015, 11:31 a.m. UTC | #1 
Hi Srini,

On 02/23/15 09:55, Srinivas Kandagatla wrote:
> From: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> 
> This patch adds PCIE support to APQ8064, tested with Ethernet on Compulab QS600 board.
> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Thanks for submitting these!
I currently have a hard time submitting anything...

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
>  arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> index 5d75666..6e62f24 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> @@ -1,4 +1,5 @@
>  #include "qcom-apq8064-v2.0.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	model = "CompuLab CM-QS600";
> @@ -40,6 +41,24 @@
>  			};
>  		};
>  
> +		/* on board fixed 3.3v supply */
> +		v3p3_pcieclk: v3p3-pcieclk {
> +			compatible = "regulator-fixed";
> +			regulator-name = "PCIE V3P3";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
> +		};
> +
> +		pci@1b500000 {
> +			status = "ok";
> +			pcie-clk-supply	= <&v3p3_pcieclk>;
> +			avdd-supply	= <&pm8921_s3>;
> +			vdd-supply	= <&pm8921_lvs6>;
> +			qcom,external-phy-refclk;
> +			reset-gpio = <&tlmm_pinmux 27 GPIO_ACTIVE_LOW>;
> +		};
> +
>  		amba {
>  			/* eMMC */
>  			sdcc1: sdcc@12400000 {
>
Srinivas Kandagatla Feb. 23, 2015, 11:43 a.m. UTC | #2 
Hi Kumar,

Sorry, I should have dropped this patch.. PCIE is still not in the 
mainline.. :-)

Will fix it in next version.

--srini
On 23/02/15 11:31, Igor Grinberg wrote:
> Hi Srini,
>
> On 02/23/15 09:55, Srinivas Kandagatla wrote:
>> From: Nicolas Dechesne <nicolas.dechesne@linaro.org>
>>
>> This patch adds PCIE support to APQ8064, tested with Ethernet on Compulab QS600 board.
>>
>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
>
> Thanks for submitting these!
> I currently have a hard time submitting anything...
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> index 5d75666..6e62f24 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> @@ -1,4 +1,5 @@
>>   #include "qcom-apq8064-v2.0.dtsi"
>> +#include <dt-bindings/gpio/gpio.h>
>>
>>   / {
>>   	model = "CompuLab CM-QS600";
>> @@ -40,6 +41,24 @@
>>   			};
>>   		};
>>
>> +		/* on board fixed 3.3v supply */
>> +		v3p3_pcieclk: v3p3-pcieclk {
>> +			compatible = "regulator-fixed";
>> +			regulator-name = "PCIE V3P3";
>> +			regulator-min-microvolt = <3300000>;
>> +			regulator-max-microvolt = <3300000>;
>> +			regulator-always-on;
>> +		};
>> +
>> +		pci@1b500000 {
>> +			status = "ok";
>> +			pcie-clk-supply	= <&v3p3_pcieclk>;
>> +			avdd-supply	= <&pm8921_s3>;
>> +			vdd-supply	= <&pm8921_lvs6>;
>> +			qcom,external-phy-refclk;
>> +			reset-gpio = <&tlmm_pinmux 27 GPIO_ACTIVE_LOW>;
>> +		};
>> +
>>   		amba {
>>   			/* eMMC */
>>   			sdcc1: sdcc@12400000 {
>>
>
Stanimir Varbanov Feb. 24, 2015, 10:23 a.m. UTC | #3 
On 02/23/2015 01:43 PM, Srinivas Kandagatla wrote:
> Hi Kumar,
> 
> Sorry, I should have dropped this patch.. PCIE is still not in the
> mainline.. :-)
> 

Srini,

Does it possible to reuse the driver which I'm trying to upstream at [1]
? I'm planing to send v2 soon.


[1] https://lkml.org/lkml/2014/12/12/557
Srinivas Kandagatla Feb. 24, 2015, 10:47 a.m. UTC | #4 
On 24/02/15 10:23, Stanimir Varbanov wrote:
> On 02/23/2015 01:43 PM, Srinivas Kandagatla wrote:
>> Hi Kumar,
>>
>> Sorry, I should have dropped this patch.. PCIE is still not in the
>> mainline.. :-)
>>
>
> Srini,
>
> Does it possible to reuse the driver which I'm trying to upstream at [1]

Yes, it should be possible, that's the plan anyway for A family.

> ? I'm planing to send v2 soon.
Great.

--srini
>
>
> [1] https://lkml.org/lkml/2014/12/12/557
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
index 5d75666..6e62f24 100644
--- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
@@ -1,4 +1,5 @@ 
 #include "qcom-apq8064-v2.0.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "CompuLab CM-QS600";
@@ -40,6 +41,24 @@ 
 			};
 		};
 
+		/* on board fixed 3.3v supply */
+		v3p3_pcieclk: v3p3-pcieclk {
+			compatible = "regulator-fixed";
+			regulator-name = "PCIE V3P3";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			regulator-always-on;
+		};
+
+		pci@1b500000 {
+			status = "ok";
+			pcie-clk-supply	= <&v3p3_pcieclk>;
+			avdd-supply	= <&pm8921_s3>;
+			vdd-supply	= <&pm8921_lvs6>;
+			qcom,external-phy-refclk;
+			reset-gpio = <&tlmm_pinmux 27 GPIO_ACTIVE_LOW>;
+		};
+
 		amba {
 			/* eMMC */
 			sdcc1: sdcc@12400000 {