diff mbox

ARM: omap-device: add missed callback for suspend-to-disk

Message ID 1424873630-6054-1-git-send-email-grygorii.strashko@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Grygorii.Strashko@linaro.org Feb. 25, 2015, 2:13 p.m. UTC
From: Grygorii Strashko <Grygorii.Strashko@linaro.org>

Add missed callback needed for supporting suspend-to-disk (hibernation) mode.

Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
---
 arch/arm/mach-omap2/omap_device.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tony Lindgren Feb. 25, 2015, 3:44 p.m. UTC | #1
* grygorii.strashko@linaro.org <grygorii.strashko@linaro.org> [150225 06:17]:
> From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> 
> Add missed callback needed for supporting suspend-to-disk (hibernation) mode.

Is this needed as a fix for the -rc series or are there still
other missing dependencies?

Regards,

Tony
 
> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> ---
>  arch/arm/mach-omap2/omap_device.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index fcd2c9e..345e18e 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -739,6 +739,9 @@ struct dev_pm_domain omap_device_pm_domain = {
>  		USE_PLATFORM_PM_SLEEP_OPS
>  		.suspend_noirq = _od_suspend_noirq,
>  		.resume_noirq = _od_resume_noirq,
> +		.freeze_noirq = _od_suspend_noirq,
> +		.thaw_noirq = _od_resume_noirq,
> +		.restore_noirq = _od_resume_noirq,
>  	}
>  };
>  
> -- 
> 1.9.1
>
Grygorii Strashko Feb. 25, 2015, 3:52 p.m. UTC | #2
On 02/25/2015 05:44 PM, Tony Lindgren wrote:
> * grygorii.strashko@linaro.org <grygorii.strashko@linaro.org> [150225 06:17]:
>> From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>>
>> Add missed callback needed for supporting suspend-to-disk (hibernation) mode.
>
> Is this needed as a fix for the -rc series or are there still
> other missing dependencies?
>

This one is not critical fix.

>
>> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>> ---
>>   arch/arm/mach-omap2/omap_device.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
>> index fcd2c9e..345e18e 100644
>> --- a/arch/arm/mach-omap2/omap_device.c
>> +++ b/arch/arm/mach-omap2/omap_device.c
>> @@ -739,6 +739,9 @@ struct dev_pm_domain omap_device_pm_domain = {
>>   		USE_PLATFORM_PM_SLEEP_OPS
>>   		.suspend_noirq = _od_suspend_noirq,
>>   		.resume_noirq = _od_resume_noirq,
>> +		.freeze_noirq = _od_suspend_noirq,
>> +		.thaw_noirq = _od_resume_noirq,
>> +		.restore_noirq = _od_resume_noirq,
>>   	}
>>   };
>>
>> --
>> 1.9.1
>>

regards,
-grygorii
Tony Lindgren Feb. 25, 2015, 3:56 p.m. UTC | #3
* Grygorii Strashko <grygorii.strashko@ti.com> [150225 07:56]:
> On 02/25/2015 05:44 PM, Tony Lindgren wrote:
> >* grygorii.strashko@linaro.org <grygorii.strashko@linaro.org> [150225 06:17]:
> >>From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> >>
> >>Add missed callback needed for supporting suspend-to-disk (hibernation) mode.
> >
> >Is this needed as a fix for the -rc series or are there still
> >other missing dependencies?
> >
> 
> This one is not critical fix.

OK thanks for confirming that.

Tony

> >>Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> >>---
> >>  arch/arm/mach-omap2/omap_device.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >>diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> >>index fcd2c9e..345e18e 100644
> >>--- a/arch/arm/mach-omap2/omap_device.c
> >>+++ b/arch/arm/mach-omap2/omap_device.c
> >>@@ -739,6 +739,9 @@ struct dev_pm_domain omap_device_pm_domain = {
> >>  		USE_PLATFORM_PM_SLEEP_OPS
> >>  		.suspend_noirq = _od_suspend_noirq,
> >>  		.resume_noirq = _od_resume_noirq,
> >>+		.freeze_noirq = _od_suspend_noirq,
> >>+		.thaw_noirq = _od_resume_noirq,
> >>+		.restore_noirq = _od_resume_noirq,
> >>  	}
> >>  };
> >>
> >>--
> >>1.9.1
> >>
> 
> regards,
> -grygorii
Kevin Hilman Feb. 25, 2015, 7:12 p.m. UTC | #4
<grygorii.strashko@linaro.org> writes:

> From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>
> Add missed callback needed for supporting suspend-to-disk (hibernation) mode.
>
> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>

Acked-by: Kevin Hilman <khilman@linaro.org>

> ---
>  arch/arm/mach-omap2/omap_device.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index fcd2c9e..345e18e 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -739,6 +739,9 @@ struct dev_pm_domain omap_device_pm_domain = {
>  		USE_PLATFORM_PM_SLEEP_OPS
>  		.suspend_noirq = _od_suspend_noirq,
>  		.resume_noirq = _od_resume_noirq,
> +		.freeze_noirq = _od_suspend_noirq,
> +		.thaw_noirq = _od_resume_noirq,
> +		.restore_noirq = _od_resume_noirq,
>  	}
>  };
Tony Lindgren March 16, 2015, 11:22 p.m. UTC | #5
* Tony Lindgren <tony@atomide.com> [150225 08:10]:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150225 07:56]:
> > On 02/25/2015 05:44 PM, Tony Lindgren wrote:
> > >* grygorii.strashko@linaro.org <grygorii.strashko@linaro.org> [150225 06:17]:
> > >>From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> > >>
> > >>Add missed callback needed for supporting suspend-to-disk (hibernation) mode.
> > >
> > >Is this needed as a fix for the -rc series or are there still
> > >other missing dependencies?
> > >
> > 
> > This one is not critical fix.
> 
> OK thanks for confirming that.

Applying into omap-for-v4.1/soc thanks.
 
> Tony
> 
> > >>Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> > >>---
> > >>  arch/arm/mach-omap2/omap_device.c | 3 +++
> > >>  1 file changed, 3 insertions(+)
> > >>
> > >>diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> > >>index fcd2c9e..345e18e 100644
> > >>--- a/arch/arm/mach-omap2/omap_device.c
> > >>+++ b/arch/arm/mach-omap2/omap_device.c
> > >>@@ -739,6 +739,9 @@ struct dev_pm_domain omap_device_pm_domain = {
> > >>  		USE_PLATFORM_PM_SLEEP_OPS
> > >>  		.suspend_noirq = _od_suspend_noirq,
> > >>  		.resume_noirq = _od_resume_noirq,
> > >>+		.freeze_noirq = _od_suspend_noirq,
> > >>+		.thaw_noirq = _od_resume_noirq,
> > >>+		.restore_noirq = _od_resume_noirq,
> > >>  	}
> > >>  };
> > >>
> > >>--
> > >>1.9.1
> > >>
> > 
> > regards,
> > -grygorii
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index fcd2c9e..345e18e 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -739,6 +739,9 @@  struct dev_pm_domain omap_device_pm_domain = {
 		USE_PLATFORM_PM_SLEEP_OPS
 		.suspend_noirq = _od_suspend_noirq,
 		.resume_noirq = _od_resume_noirq,
+		.freeze_noirq = _od_suspend_noirq,
+		.thaw_noirq = _od_resume_noirq,
+		.restore_noirq = _od_resume_noirq,
 	}
 };