| Message ID | 1425226876-5122-1-git-send-email-a.kesavan@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Mar 1, 2015 at 5:21 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote: > The alive pin controller on exynos7 does not support external gpio > interrupts. Hence, remove the eint_gpio_init call-back for it. This > fixes the following error message seen during exynos7 boot-up: > "samsung-pinctrl 10580000.pinctrl: irq number not available" > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> Tomasz, can you look at this patch? Yours, Linus Walleij
Hi Abhilash, Linus, 2015-03-02 1:21 GMT+09:00 Abhilash Kesavan <a.kesavan@samsung.com>: > The alive pin controller on exynos7 does not support external gpio > interrupts. Hence, remove the eint_gpio_init call-back for it. This > fixes the following error message seen during exynos7 boot-up: > "samsung-pinctrl 10580000.pinctrl: irq number not available" As long as "external gpio interrupts" refer to non-wake-up-capable GPIO interrupts I'm fine with this patch. Acked-by: Tomasz Figa <tomasz.figa@gmail.com> Thanks Linus for pinging and sorry for delay. Best regards, Tomasz
Hi Tomasz, On Mon, Mar 9, 2015 at 3:54 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Abhilash, Linus, > > 2015-03-02 1:21 GMT+09:00 Abhilash Kesavan <a.kesavan@samsung.com>: >> The alive pin controller on exynos7 does not support external gpio >> interrupts. Hence, remove the eint_gpio_init call-back for it. This >> fixes the following error message seen during exynos7 boot-up: >> "samsung-pinctrl 10580000.pinctrl: irq number not available" > > As long as "external gpio interrupts" refer to non-wake-up-capable > GPIO interrupts I'm fine with this patch. Yes, that was the intention. Thanks for the review. Regards, Abhilash > > Acked-by: Tomasz Figa <tomasz.figa@gmail.com> > > Thanks Linus for pinging and sorry for delay. > > Best regards, > Tomasz
On Sun, Mar 1, 2015 at 5:21 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote: > The alive pin controller on exynos7 does not support external gpio > interrupts. Hence, remove the eint_gpio_init call-back for it. This > fixes the following error message seen during exynos7 boot-up: > "samsung-pinctrl 10580000.pinctrl: irq number not available" > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> Patch applied with Tomasz ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index c8f83f9..a7e9c42 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -1324,7 +1324,6 @@ const struct samsung_pin_ctrl exynos7_pin_ctrl[] __initconst = { /* pin-controller instance 0 Alive data */ .pin_banks = exynos7_pin_banks0, .nr_banks = ARRAY_SIZE(exynos7_pin_banks0), - .eint_gpio_init = exynos_eint_gpio_init, .eint_wkup_init = exynos_eint_wkup_init, }, { /* pin-controller instance 1 BUS0 data */
The alive pin controller on exynos7 does not support external gpio interrupts. Hence, remove the eint_gpio_init call-back for it. This fixes the following error message seen during exynos7 boot-up: "samsung-pinctrl 10580000.pinctrl: irq number not available" Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> --- drivers/pinctrl/samsung/pinctrl-exynos.c | 1 - 1 file changed, 1 deletion(-)