diff mbox

[14/15] ARM: cns3xxx: don't export static symbol

Message ID 1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Julia Lawall March 11, 2015, 4:56 p.m. UTC 
From: Julia Lawall <Julia.Lawall@lip6.fr>

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@

-EXPORT_SYMBOL(f);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 arch/arm/mach-cns3xxx/pm.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Arnd Bergmann March 11, 2015, 9:09 p.m. UTC | #1 
On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?

	Arnd
Krzysztof Hałasa March 13, 2015, 5:59 a.m. UTC | #2 
Arnd Bergmann <arnd@arndb.de> writes:

> Looks good. Krzysztof, do you want to pick this up and send me a
> pull request together with other patches, or should I apply this
> to the arm-soc fixes directly?

The latter, please.
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
Arnd Bergmann March 13, 2015, 10:04 a.m. UTC | #3 
On Friday 13 March 2015 06:59:38 Krzysztof Ha?asa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > Looks good. Krzysztof, do you want to pick this up and send me a
> > pull request together with other patches, or should I apply this
> > to the arm-soc fixes directly?
> 
> The latter, please.
> Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
> -- 

Applied to next/fixes-non-critical with your Ack, thanks!

	Arnd
diff mbox

Patch

diff -u -p a/arch/arm/mach-cns3xxx/pm.c b/arch/arm/mach-cns3xxx/pm.c
--- a/arch/arm/mach-cns3xxx/pm.c
+++ b/arch/arm/mach-cns3xxx/pm.c
@@ -73,7 +73,6 @@  static void cns3xxx_pwr_soft_rst_force(u
 
 	__raw_writel(reg, PM_SOFT_RST_REG);
 }
-EXPORT_SYMBOL(cns3xxx_pwr_soft_rst_force);
 
 void cns3xxx_pwr_soft_rst(unsigned int block)
 {