| Message ID | 1427792170-13162-1-git-send-email-nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Le 31/03/2015 10:56, Nicolas Ferre a écrit : > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) > the macb1 interface refuses to work properly because it tries > to cling to address 0 which isn't able to communicate in broadcast with > the mac anymore. The micrel phy on the board is actually configured > to show up at address 1. > Adding the phy node and its real address fixes the issue. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Johan Hovold <johan@kernel.org> > Cc: <stable@vger.kernel.org> #3.19 > --- Arnd, Olof, Kevin, It seems late but, is it possible to queue this patch as a 4.0 fixes? Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used by u-boot previously. Bye, > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index fec1fca2ad66..6c4bc53cbf4e 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -167,7 +167,13 @@ > > macb1: ethernet@f802c000 { > phy-mode = "rmii"; > + #address-cells = <1>; > + #size-cells = <0>; > status = "okay"; > + > + ethernet-phy@1 { > + reg = <0x1>; > + }; > }; > > dbgu: serial@ffffee00 { >
On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote: > Le 31/03/2015 10:56, Nicolas Ferre a écrit : > > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) > > the macb1 interface refuses to work properly because it tries > > to cling to address 0 which isn't able to communicate in broadcast with > > the mac anymore. The micrel phy on the board is actually configured > > to show up at address 1. > > Adding the phy node and its real address fixes the issue. > > > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > Cc: Johan Hovold <johan@kernel.org> > > Cc: <stable@vger.kernel.org> #3.19 > > --- > > Arnd, Olof, Kevin, > > It seems late but, is it possible to queue this patch as a 4.0 fixes? > > Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used > by u-boot previously. Sure, resend it to arm@kernel.org. -Olof
On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote: > On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote: > > Le 31/03/2015 10:56, Nicolas Ferre a écrit : > > > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) > > > the macb1 interface refuses to work properly because it tries > > > to cling to address 0 which isn't able to communicate in broadcast with > > > the mac anymore. The micrel phy on the board is actually configured > > > to show up at address 1. > > > Adding the phy node and its real address fixes the issue. > > > > > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > > Cc: Johan Hovold <johan@kernel.org> > > > Cc: <stable@vger.kernel.org> #3.19 > > > --- > > > > Arnd, Olof, Kevin, > > > > It seems late but, is it possible to queue this patch as a 4.0 fixes? > > > > Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used > > by u-boot previously. > > Sure, resend it to arm@kernel.org. Nevermind, I ended up picking it up from the list. Applied. -Olof
Le 03/04/2015 23:56, Olof Johansson a écrit : > On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote: >> On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote: >>> Le 31/03/2015 10:56, Nicolas Ferre a écrit : >>>> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) >>>> the macb1 interface refuses to work properly because it tries >>>> to cling to address 0 which isn't able to communicate in broadcast with >>>> the mac anymore. The micrel phy on the board is actually configured >>>> to show up at address 1. >>>> Adding the phy node and its real address fixes the issue. >>>> >>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> >>>> Cc: Johan Hovold <johan@kernel.org> >>>> Cc: <stable@vger.kernel.org> #3.19 >>>> --- >>> >>> Arnd, Olof, Kevin, >>> >>> It seems late but, is it possible to queue this patch as a 4.0 fixes? >>> >>> Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used >>> by u-boot previously. >> >> Sure, resend it to arm@kernel.org. > > Nevermind, I ended up picking it up from the list. Applied. Cool: thanks Olof! Bye,
diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index fec1fca2ad66..6c4bc53cbf4e 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -167,7 +167,13 @@ macb1: ethernet@f802c000 { phy-mode = "rmii"; + #address-cells = <1>; + #size-cells = <0>; status = "okay"; + + ethernet-phy@1 { + reg = <0x1>; + }; }; dbgu: serial@ffffee00 {
After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) the macb1 interface refuses to work properly because it tries to cling to address 0 which isn't able to communicate in broadcast with the mac anymore. The micrel phy on the board is actually configured to show up at address 1. Adding the phy node and its real address fixes the issue. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Johan Hovold <johan@kernel.org> Cc: <stable@vger.kernel.org> #3.19 --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++ 1 file changed, 6 insertions(+)