diff mbox

ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

Message ID 1429043846-28731-1-git-send-email-stefan.wahren@i2se.com (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Wahren April 14, 2015, 8:37 p.m. UTC 
The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:

echo 0 > /sys/class/leds/green/brightness
[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11

This patch fixes the issue by setting dr_mode to "host" in the dts file.

Reported-by: Harald Geyer <harald@ccbib.org>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam April 14, 2015, 8:43 p.m. UTC | #1 
On Tue, Apr 14, 2015 at 5:37 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
>
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
>
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
>
> Reported-by: Harald Geyer <harald@ccbib.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks
Marek Vasut April 15, 2015, 2:59 a.m. UTC | #2 
On Tuesday, April 14, 2015 at 10:37:26 PM, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
> 
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
> 
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
> 
> Reported-by: Harald Geyer <harald@ccbib.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Peter Chen April 15, 2015, 3:32 a.m. UTC | #3 
On Tue, Apr 14, 2015 at 08:37:26PM +0000, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
> 
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
> 
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
> 
> Reported-by: Harald Geyer <harald@ccbib.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
> index 7e6eef2..3b2d74d 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -93,6 +93,7 @@
>  
>  	ahb@80080000 {
>  		usb0: usb@80080000 {
> +			dr_mode = "host";
>  			vbus-supply = <&reg_usb0_vbus>;
>  			status = "okay";
>  		};
> -- 
> 1.7.9.5
> 

If this board has only host function, I am ok for it.

Acked-by: Peter Chen <peter.chen@freescale.com>
Stefan Wahren April 15, 2015, 7:11 p.m. UTC | #4 
Hi Peter,

> Peter Chen <peter.chen@freescale.com> hat am 15. April 2015 um 05:32
> geschrieben:
>
>
> [...]
>
> If this board has only host function, I am ok for it.

Yes, all 4 boards (Maxi [1], Micro [2], Mini [3], Nano [4]) have only host
function.

>
> Acked-by: Peter Chen <peter.chen@freescale.com>

Thanks
Stefan

[1] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Maxi/iMX233-OLINUXINO-MAXI_Rev_D.pdf
[2] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Micro/iMX233-OLinuXino-Micro_Rev_D.pdf
[3] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Mini/iMX233-OLINUXINO-MINI_Rev_C.sch.pdf
[4] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-NANO/iMX233-OLinuXino-NANO_Rev_B.pdf

>
> --
>
> Best Regards,
> Peter Chen
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo April 27, 2015, 12:26 p.m. UTC | #5 
On Tue, Apr 14, 2015 at 08:37:26PM +0000, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
> 
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
> 
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
> 
> Reported-by: Harald Geyer <harald@ccbib.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 7e6eef2..3b2d74d 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -93,6 +93,7 @@ 
 
 	ahb@80080000 {
 		usb0: usb@80080000 {
+			dr_mode = "host";
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};