diff mbox

ARM: dts: imx25: Add missing '#pwm-cells' property for pwm4

Message ID 1429706430-9495-1-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam April 22, 2015, 12:40 p.m. UTC
All pwm ports pass the '#pwm-cells' property, except pw4.

Fix it by passing '#pwm-cells' property for pwm4.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx25.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Markus Pargmann April 22, 2015, 2:14 p.m. UTC | #1
Hi Fabio,

On Wed, Apr 22, 2015 at 09:40:30AM -0300, Fabio Estevam wrote:
> All pwm ports pass the '#pwm-cells' property, except pw4.
> 
> Fix it by passing '#pwm-cells' property for pwm4.

I already sent the same patch a month ago [1]. Forgot to resend it.

Thanks,

Markus

[1] http://www.spinics.net/lists/arm-kernel/msg408159.html

> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e4d3aec..677f81d 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -428,6 +428,7 @@
>  
>  			pwm4: pwm@53fc8000 {
>  				compatible = "fsl,imx25-pwm", "fsl,imx27-pwm";
> +				#pwm-cells = <2>;
>  				reg = <0x53fc8000 0x4000>;
>  				clocks = <&clks 108>, <&clks 52>;
>  				clock-names = "ipg", "per";
> -- 
> 1.9.1
> 
> 
>
Fabio Estevam April 23, 2015, 10:55 a.m. UTC | #2
Hi Markus,

On Wed, Apr 22, 2015 at 11:14 AM, Markus Pargmann <mpa@pengutronix.de> wrote:
> Hi Fabio,
>
> On Wed, Apr 22, 2015 at 09:40:30AM -0300, Fabio Estevam wrote:
>> All pwm ports pass the '#pwm-cells' property, except pw4.
>>
>> Fix it by passing '#pwm-cells' property for pwm4.
>
> I already sent the same patch a month ago [1]. Forgot to resend it.

Ok, I haven't seen it. Could you please resend it with stable on Cc?

Thanks
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e4d3aec..677f81d 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -428,6 +428,7 @@ 
 
 			pwm4: pwm@53fc8000 {
 				compatible = "fsl,imx25-pwm", "fsl,imx27-pwm";
+				#pwm-cells = <2>;
 				reg = <0x53fc8000 0x4000>;
 				clocks = <&clks 108>, <&clks 52>;
 				clock-names = "ipg", "per";