diff mbox

[v3,3/3] arm64: dts: Add mediatek MT8173 earlycon support

Message ID 1430228434-31779-4-git-send-email-eddie.huang@mediatek.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eddie Huang (黃智傑) April 28, 2015, 1:40 p.m. UTC
Add earlycon support to mediatek MT8173 evaluation board dts.

Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Sascha Hauer April 29, 2015, 6:44 a.m. UTC | #1
Hi Eddie,

On Tue, Apr 28, 2015 at 09:40:34PM +0800, Eddie Huang wrote:
> Add earlycon support to mediatek MT8173 evaluation board dts.

This is not about earlycon support. It adds the stdout-path property
which is generally about console. It only happens to used for earlycon,
but would be used as a regular console aswell if it wasn't broken for
some kernel revisisions.

>  
> -	chosen { };
> +	chosen {
> +		linux,stdout-path = &uart0;
> +	};

Please use stdout-path, without the 'linux,'.

Sascha
Vineet Gupta April 29, 2015, 8:19 a.m. UTC | #2
On Wednesday 29 April 2015 12:15 PM, Sascha Hauer wrote:
> Hi Eddie,
>
> On Tue, Apr 28, 2015 at 09:40:34PM +0800, Eddie Huang wrote:
>> Add earlycon support to mediatek MT8173 evaluation board dts.
> This is not about earlycon support. It adds the stdout-path property
> which is generally about console.

Indeed, this is shorter way of specifying the default console by referring to uart
device.

>  It only happens to used for earlycon,
> but would be used as a regular console aswell if it wasn't broken for
> some kernel revisisions.

Really - I'm confused. When I last tried this for arc_uart (in 3.17 time frame),
it would setup default console, but to use it for earlycon we needed
bootargs=earlycon in chosen. However I had to revet that change since OF core
still was fixing a few things in that area.

See mainline 22524b02b17b901f28 ("Revert "ARC: [arcfpga] stdout-path now suffices
for earlycon/console"")

-Vineet

>
>>  
>> -	chosen { };
>> +	chosen {
>> +		linux,stdout-path = &uart0;
>> +	};
> Please use stdout-path, without the 'linux,'.
>
> Sascha
>
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 43d5401..d4cf751 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -30,7 +30,9 @@ 
 		reg = <0 0x40000000 0 0x80000000>;
 	};
 
-	chosen { };
+	chosen {
+		linux,stdout-path = &uart0;
+	};
 };
 
 &uart0 {