| Message ID | 1431381653-25356-2-git-send-email-manabian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 12 May 2015 00:00:47 Joachim Eastwood wrote: > Add support for NXP's LPC18xx (Cortex-M3) and LPC43xx (Cortex-M4) > SoCs. These SoCs are NXP's high preformance MCU line and can run at > clock speeds up to 180 MHz for LPC18xx and 204 MHz for LPC43xx. > > LPC43xx is more or less a LPC18xx with a Cortex-M4F core and a few > extra peripherals. The LPC43xx series also features one or two > Cortex-M0 cores that can be used to offload the main M4 core. > > Signed-off-by: Joachim Eastwood <manabian@gmail.com> > Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > Applied to next/soc, thanks! Arnd
On Tue, May 12, 2015 at 12:00 AM, Joachim Eastwood <manabian@gmail.com> wrote: > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS > default 0x20201000 if DEBUG_BCM2835 > default 0x3e000000 if DEBUG_BCM_KONA_UART > default 0x4000e400 if DEBUG_LL_UART_EFM32 > + default 0x40081000 if ARCH_LPC18XX This will be used in any multi-platform kernel with DEBUG_LL=y, possible overriding a correct value, even if low-level LPC18XX debug support itself (what's the config option for that, I couldn't find it?) is disabled. Please make this dependent on an appropriate DEBUG_LPC18XX option. Thanks! I noticed this was already applied... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 19 May 2015 at 09:26, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, May 12, 2015 at 12:00 AM, Joachim Eastwood <manabian@gmail.com> wrote: >> --- a/arch/arm/Kconfig.debug >> +++ b/arch/arm/Kconfig.debug >> @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS >> default 0x20201000 if DEBUG_BCM2835 >> default 0x3e000000 if DEBUG_BCM_KONA_UART >> default 0x4000e400 if DEBUG_LL_UART_EFM32 >> + default 0x40081000 if ARCH_LPC18XX > > This will be used in any multi-platform kernel with DEBUG_LL=y, possible > overriding a correct value, even if low-level LPC18XX debug support itself > (what's the config option for that, I couldn't find it?) is disabled. Right now LPC18xx can't be a part of any multi-platform kernel. > Please make this dependent on an appropriate DEBUG_LPC18XX > option. Thanks! But anyways defining a DEBUG_LPC18XX symbol seems to be what most other platforms do. I'll send a follow up patch defining DEBUG_LPC18XX and then use that in DEBUG_UART_PHYS. regards, Joachim Eastwood
Hi Joachim, On Tue, May 19, 2015 at 10:39 AM, Joachim Eastwood <manabian@gmail.com> wrote: > On 19 May 2015 at 09:26, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> On Tue, May 12, 2015 at 12:00 AM, Joachim Eastwood <manabian@gmail.com> wrote: >>> --- a/arch/arm/Kconfig.debug >>> +++ b/arch/arm/Kconfig.debug >>> @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS >>> default 0x20201000 if DEBUG_BCM2835 >>> default 0x3e000000 if DEBUG_BCM_KONA_UART >>> default 0x4000e400 if DEBUG_LL_UART_EFM32 >>> + default 0x40081000 if ARCH_LPC18XX >> >> This will be used in any multi-platform kernel with DEBUG_LL=y, possible >> overriding a correct value, even if low-level LPC18XX debug support itself >> (what's the config option for that, I couldn't find it?) is disabled. > > Right now LPC18xx can't be a part of any multi-platform kernel. Oops. Sorry for the noise, I completely overlooked that... So it doesn't bite us (yet). >> Please make this dependent on an appropriate DEBUG_LPC18XX >> option. Thanks! > > But anyways defining a DEBUG_LPC18XX symbol seems to be what most > other platforms do. I'll send a follow up patch defining DEBUG_LPC18XX > and then use that in DEBUG_UART_PHYS. Nevertheless, IMHO it's still good to have, thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tuesday 19 May 2015 10:45:14 Geert Uytterhoeven wrote: > Hi Joachim, > > On Tue, May 19, 2015 at 10:39 AM, Joachim Eastwood <manabian@gmail.com> wrote: > > On 19 May 2015 at 09:26, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> On Tue, May 12, 2015 at 12:00 AM, Joachim Eastwood <manabian@gmail.com> wrote: > >>> --- a/arch/arm/Kconfig.debug > >>> +++ b/arch/arm/Kconfig.debug > >>> @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS > >>> default 0x20201000 if DEBUG_BCM2835 > >>> default 0x3e000000 if DEBUG_BCM_KONA_UART > >>> default 0x4000e400 if DEBUG_LL_UART_EFM32 > >>> + default 0x40081000 if ARCH_LPC18XX > >> > >> This will be used in any multi-platform kernel with DEBUG_LL=y, possible > >> overriding a correct value, even if low-level LPC18XX debug support itself > >> (what's the config option for that, I couldn't find it?) is disabled. > > > > Right now LPC18xx can't be a part of any multi-platform kernel. > > Oops. Sorry for the noise, I completely overlooked that... > So it doesn't bite us (yet). I actually have a patch to convert all remaining 'if ARCH_*' dependencies in this file the way you suggest here, and noticed the LPC18XX addition when rebasing that one yesterday. > >> Please make this dependent on an appropriate DEBUG_LPC18XX > >> option. Thanks! > > > > But anyways defining a DEBUG_LPC18XX symbol seems to be what most > > other platforms do. I'll send a follow up patch defining DEBUG_LPC18XX > > and then use that in DEBUG_UART_PHYS. > > Nevertheless, IMHO it's still good to have, thanks! Agreed. Arnd
Hi Arnd, On Tue, May 19, 2015 at 11:11 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 19 May 2015 10:45:14 Geert Uytterhoeven wrote: >> On Tue, May 19, 2015 at 10:39 AM, Joachim Eastwood <manabian@gmail.com> wrote: >> > On 19 May 2015 at 09:26, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> >> On Tue, May 12, 2015 at 12:00 AM, Joachim Eastwood <manabian@gmail.com> wrote: >> >>> --- a/arch/arm/Kconfig.debug >> >>> +++ b/arch/arm/Kconfig.debug >> >>> @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS >> >>> default 0x20201000 if DEBUG_BCM2835 >> >>> default 0x3e000000 if DEBUG_BCM_KONA_UART >> >>> default 0x4000e400 if DEBUG_LL_UART_EFM32 >> >>> + default 0x40081000 if ARCH_LPC18XX >> >> >> >> This will be used in any multi-platform kernel with DEBUG_LL=y, possible >> >> overriding a correct value, even if low-level LPC18XX debug support itself >> >> (what's the config option for that, I couldn't find it?) is disabled. >> > >> > Right now LPC18xx can't be a part of any multi-platform kernel. >> >> Oops. Sorry for the noise, I completely overlooked that... >> So it doesn't bite us (yet). > > I actually have a patch to convert all remaining 'if ARCH_*' dependencies > in this file the way you suggest here, and noticed the LPC18XX addition Would be great to see that go in! Thanks! > when rebasing that one yesterday. I noticed because I have a lazy patch to remove all non-shmobile defaults ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 45df48ba0b12..26a74c460be7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -586,6 +586,26 @@ config ARCH_W90X900 <http://www.nuvoton.com/hq/enu/ProductAndSales/ProductLines/ ConsumerElectronicsIC/ARMMicrocontroller/ARMMicrocontroller> +config ARCH_LPC18XX + bool "NXP LPC18xx/LPC43xx" + depends on !MMU + select ARCH_HAS_RESET_CONTROLLER + select ARCH_REQUIRE_GPIOLIB + select ARM_AMBA + select ARM_NVIC + select AUTO_ZRELADDR + select CLKSRC_LPC32XX + select COMMON_CLK + select CPU_V7M + select GENERIC_CLOCKEVENTS + select NO_IOPORT_MAP + select PINCTRL + select SPARSE_IRQ + select USE_OF + help + Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 + high performance microcontrollers. + config ARCH_LPC32XX bool "NXP LPC32XX" select ARCH_REQUIRE_GPIOLIB diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 0c12ffb155a2..b3b6469350c1 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1359,6 +1359,7 @@ config DEBUG_UART_PHYS default 0x20201000 if DEBUG_BCM2835 default 0x3e000000 if DEBUG_BCM_KONA_UART default 0x4000e400 if DEBUG_LL_UART_EFM32 + default 0x40081000 if ARCH_LPC18XX default 0x40090000 if ARCH_LPC32XX default 0x40100000 if DEBUG_PXA_UART1 default 0x42000000 if ARCH_GEMINI @@ -1562,7 +1563,7 @@ config UNCOMPRESS_INCLUDE string default "debug/uncompress.h" if ARCH_MULTIPLATFORM || ARCH_MSM || \ PLAT_SAMSUNG || ARCH_EFM32 || \ - ARCH_SHMOBILE_LEGACY + ARCH_SHMOBILE_LEGACY || ARCH_LPC18XX default "mach/uncompress.h" config EARLY_PRINTK diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 985227cbbd1b..90ddf851aece 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -167,6 +167,7 @@ machine-$(CONFIG_ARCH_IOP33X) += iop33x machine-$(CONFIG_ARCH_IXP4XX) += ixp4xx machine-$(CONFIG_ARCH_KEYSTONE) += keystone machine-$(CONFIG_ARCH_KS8695) += ks8695 +machine-$(CONFIG_ARCH_LPC18XX) += lpc18xx machine-$(CONFIG_ARCH_LPC32XX) += lpc32xx machine-$(CONFIG_ARCH_MESON) += meson machine-$(CONFIG_ARCH_MMP) += mmp diff --git a/arch/arm/mach-lpc18xx/Makefile b/arch/arm/mach-lpc18xx/Makefile new file mode 100644 index 000000000000..bd0b7b5d6e9d --- /dev/null +++ b/arch/arm/mach-lpc18xx/Makefile @@ -0,0 +1 @@ +obj-y += board-dt.o diff --git a/arch/arm/mach-lpc18xx/Makefile.boot b/arch/arm/mach-lpc18xx/Makefile.boot new file mode 100644 index 000000000000..eacfc3f5c33e --- /dev/null +++ b/arch/arm/mach-lpc18xx/Makefile.boot @@ -0,0 +1,3 @@ +# Empty file waiting for deletion once Makefile.boot isn't needed any more. +# Patch waits for application at +# http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7889/1 . diff --git a/arch/arm/mach-lpc18xx/board-dt.c b/arch/arm/mach-lpc18xx/board-dt.c new file mode 100644 index 000000000000..fdcee78d1bc4 --- /dev/null +++ b/arch/arm/mach-lpc18xx/board-dt.c @@ -0,0 +1,22 @@ +/* + * Device Tree board file for NXP LPC18xx/43xx + * + * Copyright (C) 2015 Joachim Eastwood <manabian@gmail.com> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +#include <asm/mach/arch.h> + +static const char *const lpc18xx_43xx_compat[] __initconst = { + "nxp,lpc1850", + "nxp,lpc4350", + "nxp,lpc4370", + NULL +}; + +DT_MACHINE_START(LPC18XXDT, "NXP LPC18xx/43xx (Device Tree)") + .dt_compat = lpc18xx_43xx_compat, +MACHINE_END