| Message ID | 1431583811-25780-5-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 14, 2015 at 02:10:08PM +0800, Chen-Yu Tsai wrote: > The PRCM is a collection of clock controls, reset controls, and various > power switches/gates. Some of these can be independently listed and > supported, while a number of CPU related ones are used in tandem with > CPUCFG for SMP bringup and CPU hotplugging. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun9i-a80.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi > index c45735398f6a..1507bd2a88f0 100644 > --- a/arch/arm/boot/dts/sun9i-a80.dtsi > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi > @@ -797,6 +797,11 @@ > interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; > }; > > + prcm@01700000 { > + compatible = "allwinner,sun9i-a80-prcm"; > + reg = <0x08001400 0x200>; > + }; > + The unit address doesn't match the content of the reg property. Maxime
On Sun, May 17, 2015 at 10:54 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Thu, May 14, 2015 at 02:10:08PM +0800, Chen-Yu Tsai wrote: >> The PRCM is a collection of clock controls, reset controls, and various >> power switches/gates. Some of these can be independently listed and >> supported, while a number of CPU related ones are used in tandem with >> CPUCFG for SMP bringup and CPU hotplugging. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun9i-a80.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi >> index c45735398f6a..1507bd2a88f0 100644 >> --- a/arch/arm/boot/dts/sun9i-a80.dtsi >> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi >> @@ -797,6 +797,11 @@ >> interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; >> }; >> >> + prcm@01700000 { >> + compatible = "allwinner,sun9i-a80-prcm"; >> + reg = <0x08001400 0x200>; >> + }; >> + > > The unit address doesn't match the content of the reg property. Obvious copy-paste error (facepalm) ChenYu
diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi index c45735398f6a..1507bd2a88f0 100644 --- a/arch/arm/boot/dts/sun9i-a80.dtsi +++ b/arch/arm/boot/dts/sun9i-a80.dtsi @@ -797,6 +797,11 @@ interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; }; + prcm@01700000 { + compatible = "allwinner,sun9i-a80-prcm"; + reg = <0x08001400 0x200>; + }; + r_uart: serial@08002800 { compatible = "snps,dw-apb-uart"; reg = <0x08002800 0x400>;
The PRCM is a collection of clock controls, reset controls, and various power switches/gates. Some of these can be independently listed and supported, while a number of CPU related ones are used in tandem with CPUCFG for SMP bringup and CPU hotplugging. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun9i-a80.dtsi | 5 +++++ 1 file changed, 5 insertions(+)