diff mbox

[2/2] doc: dt: add documentation for nxp,lpc1850-usb-otg-phy

Message ID 1431797277-4906-3-git-send-email-manabian@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joachim Eastwood May 16, 2015, 5:27 p.m. UTC
Add binding documentation for nxp,lpc1850-usb-otg-phy. This PHY
can found on NXP LPC18xx and LPC43xx devices.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
 .../bindings/phy/nxp,lpc1850-usb-otg-phy.txt          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt

Comments

Kishon Vijay Abraham I May 21, 2015, 12:59 p.m. UTC | #1
On Saturday 16 May 2015 10:57 PM, Joachim Eastwood wrote:
> Add binding documentation for nxp,lpc1850-usb-otg-phy. This PHY

%s/nxp,lpc1850-usb-otg-phy/NXP LPC18xx/43xx USB OTG PHY
> can found on NXP LPC18xx and LPC43xx devices.

Fix $subject to something like 'dt_bindings: Add NXP LPC18xx/43xx USB OTG PHY 
bindings'
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
>   .../bindings/phy/nxp,lpc1850-usb-otg-phy.txt          | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
> new file mode 100644
> index 000000000000..3da60ca04a42
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt

phy-lpc18xx-usb-otg.txt?

Thanks
Kishon
Joachim Eastwood May 21, 2015, 2:09 p.m. UTC | #2
Hi Kishon,

On 21 May 2015 at 14:59, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
>
> On Saturday 16 May 2015 10:57 PM, Joachim Eastwood wrote:
>>
>> Add binding documentation for nxp,lpc1850-usb-otg-phy. This PHY
>
>
> %s/nxp,lpc1850-usb-otg-phy/NXP LPC18xx/43xx USB OTG PHY

Sure.

>>
>> can found on NXP LPC18xx and LPC43xx devices.
>
>
> Fix $subject to something like 'dt_bindings: Add NXP LPC18xx/43xx USB OTG
> PHY bindings'

okey.

>>
>>
>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>> ---
>>   .../bindings/phy/nxp,lpc1850-usb-otg-phy.txt          | 19
>> +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
>> b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
>> new file mode 100644
>> index 000000000000..3da60ca04a42
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
>
>
> phy-lpc18xx-usb-otg.txt?

Fine by me.

Thanks for your comments, Kishon.


regards,
Joachim Eastwood
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
new file mode 100644
index 000000000000..3da60ca04a42
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/nxp,lpc1850-usb-otg-phy.txt
@@ -0,0 +1,19 @@ 
+NXP LPC18xx/43xx internal USB OTG PHY binding
+---------------------------------------------
+
+This file contains documentation for the internal USB OTG PHY found
+in NXP LPC18xx and LPC43xx SoCs.
+
+Required properties:
+- compatible	: must be "nxp,lpc1850-usb-otg-phy"
+- clocks	: must be exactly one entry
+See: Documentation/devicetree/bindings/clock/clock-bindings.txt
+- #phy-cells	: must be 0 for this phy
+See: Documentation/devicetree/bindings/phy/phy-bindings.txt
+
+Example:
+usb0_otg_phy: usb0-otg-phy {
+	compatible = "nxp,lpc1850-usb-otg-phy";
+	clocks = <&ccu1 CLK_USB0>;
+	#phy-cells = <0>;
+};