diff mbox

[1/2] ARM: dts: nitrogen6x: use simple-panel instead of display-timings for LVDS0

Message ID 1431804202-11067-2-git-send-email-eric.nelson@boundarydevices.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Nelson May 16, 2015, 7:23 p.m. UTC
Also add alias for backlight_lvds and connect it to the display.

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

Comments

Lothar Waßmann May 18, 2015, 5:58 a.m. UTC | #1
Hi,

> Also add alias for backlight_lvds and connect it to the display.
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 30 +++++++++++++++++-------------
>  1 file changed, 17 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index fd096dc..712c5ec 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -122,7 +122,7 @@
>  		status = "okay";
>  	};
>  
> -	backlight_lvds {
> +	backlight_lvds: backlight_lvds {
>
The patch does not add an 'alias', but a 'label'.


Lothar Waßmann
Eric Nelson May 18, 2015, 2:12 p.m. UTC | #2
On 05/17/2015 10:58 PM, Lothar Waßmann wrote:
> Hi,
> 
>> Also add alias for backlight_lvds and connect it to the display.
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 30 +++++++++++++++++-------------
>>  1 file changed, 17 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
>> index fd096dc..712c5ec 100644
>> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
>> @@ -122,7 +122,7 @@
>>  		status = "okay";
>>  	};
>>  
>> -	backlight_lvds {
>> +	backlight_lvds: backlight_lvds {
>>
> The patch does not add an 'alias', but a 'label'.
> 

Good catch.

Thanks for the clarification.
Eric Nelson May 19, 2015, 3:50 p.m. UTC | #3
Patch originated with informal submission by Philipp Zabel:
	http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/337115.html

Update the LVDS0 configuration for imx6qdl-nitrogen6x and imx6qdl-sabrelite
to use simple panel to allow the connection of backlights and simplify the
process of (re)configuring displays.

A U-Boot script to configure the displays based on detection of the
touch controller is available for reference here:

	https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript-mainline.txt

Addition of panel hannstar,hsd100pxn1 is queued for 4.2:
	https://patchwork.kernel.org/patch/6212451/

Eric Nelson (2):
  ARM: dts: nitrogen6x: use simple-panel instead of display-timings for
    LVDS0
  ARM: dts: sabrelite: use simple-panel instead of display-timings for
    LVDS0

V2 changes commit messages to use proper name of 'label' instead of 'alias'

 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 30 +++++++++++++++++-------------
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi  | 30 +++++++++++++++++-------------
 2 files changed, 34 insertions(+), 26 deletions(-)
Shawn Guo May 21, 2015, 12:27 a.m. UTC | #4
On Tue, May 19, 2015 at 08:50:14AM -0700, Eric Nelson wrote:
> Eric Nelson (2):
>   ARM: dts: nitrogen6x: use simple-panel instead of display-timings for
>     LVDS0
>   ARM: dts: sabrelite: use simple-panel instead of display-timings for
>     LVDS0

Applied both, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index fd096dc..712c5ec 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -122,7 +122,7 @@ 
 		status = "okay";
 	};
 
-	backlight_lvds {
+	backlight_lvds: backlight_lvds {
 		compatible = "pwm-backlight";
 		pwms = <&pwm4 0 5000000>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;
@@ -130,6 +130,17 @@ 
 		power-supply = <&reg_3p3v>;
 		status = "okay";
 	};
+
+	panel {
+		compatible = "hannstar,hsd100pxn1";
+		backlight = <&backlight_lvds>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds0_out>;
+			};
+		};
+	};
 };
 
 &audmux {
@@ -379,18 +390,11 @@ 
 		fsl,data-width = <18>;
 		status = "okay";
 
-		display-timings {
-			native-mode = <&timing0>;
-			timing0: hsd100pxn1 {
-				clock-frequency = <65000000>;
-				hactive = <1024>;
-				vactive = <768>;
-				hback-porch = <220>;
-				hfront-porch = <40>;
-				vback-porch = <21>;
-				vfront-porch = <7>;
-				hsync-len = <60>;
-				vsync-len = <10>;
+		port@4 {
+			reg = <4>;
+
+			lvds0_out: endpoint {
+				remote-endpoint = <&panel_in>;
 			};
 		};
 	};