| Message ID | 1432846332-17692-1-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/28/2015 01:52 PM, Stephen Boyd wrote: > Add the call to of_clk_set_defaults() into the amba probe path so > that devices on the amba bus can use the assigned rates and > parents feature of the common clock framework. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- Shall I put this into the patch tracker? Turns out it wasn't needed for the hisi stuff immediately.
Hi Russell, Could you spend several minutes to review Stephen's patch? Thanks, Bintian On 2015/7/7 7:57, Stephen Boyd wrote: > On 05/28/2015 01:52 PM, Stephen Boyd wrote: >> Add the call to of_clk_set_defaults() into the amba probe path so >> that devices on the amba bus can use the assigned rates and >> parents feature of the common clock framework. >> >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> >> --- > > Shall I put this into the patch tracker? Turns out it wasn't needed for > the hisi stuff immediately. >
On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote: > Hi Russell, > > Could you spend several minutes to review Stephen's patch? Sorry, I'm busy this week, I need to sort out my git tree, get some fixes out which should've been pushed during the merge window, and other stuff. I'm not going to have much time to read email, let alone do reviews. Please be patient.
On 2015/7/7 17:33, Russell King - ARM Linux wrote: > On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote: >> Hi Russell, >> >> Could you spend several minutes to review Stephen's patch? > > Sorry, I'm busy this week, I need to sort out my git tree, get some fixes > out which should've been pushed during the merge window, and other stuff. > I'm not going to have much time to read email, let alone do reviews. > Please be patient. > No problem, just keep your own pace. Thanks, Bintian
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index f0099360039e..350ed93d4281 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -19,6 +19,7 @@ #include <linux/amba/bus.h> #include <linux/sizes.h> #include <linux/limits.h> +#include <linux/clk/clk-conf.h> #include <asm/irq.h> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev) int ret; do { + ret = of_clk_set_defaults(dev->of_node, false); + if (ret < 0) + break; + ret = dev_pm_domain_attach(dev, true); if (ret == -EPROBE_DEFER) break;
Add the call to of_clk_set_defaults() into the amba probe path so that devices on the amba bus can use the assigned rates and parents feature of the common clock framework. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- Russell, Can you please ack this change? We're going to send it through the clk tree because hisi clock requires it. Thanks, Stephen drivers/amba/bus.c | 5 +++++ 1 file changed, 5 insertions(+)