| Message ID | 1433366298-30016-1-git-send-email-paul.gortmaker@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04.06.2015 06:18, Paul Gortmaker wrote: > This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") > and also contains modular function calls so it should explicitly include > module.h to avoid compile breakage during pending header shuffles. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On 03-06-15, 17:18, Paul Gortmaker wrote: > This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") > and also contains modular function calls so it should explicitly include > module.h to avoid compile breakage during pending header shuffles. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > > [ patch will be appended to the implicit include fixup series, see: > https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com > for the original series posting.] > > drivers/cpufreq/exynos-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c > index 82d2fbb20f7e..4c157302365f 100644 > --- a/drivers/cpufreq/exynos-cpufreq.c > +++ b/drivers/cpufreq/exynos-cpufreq.c > @@ -10,6 +10,7 @@ > */ > > #include <linux/kernel.h> > +#include <linux/module.h> > #include <linux/err.h> > #include <linux/clk.h> > #include <linux/io.h> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Wednesday, June 03, 2015 05:18:18 PM Paul Gortmaker wrote: > This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") > and also contains modular function calls so it should explicitly include > module.h to avoid compile breakage during pending header shuffles. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> I'm assuming that this will go in via the Samsung tree. > --- > > [ patch will be appended to the implicit include fixup series, see: > https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com > for the original series posting.] > > drivers/cpufreq/exynos-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c > index 82d2fbb20f7e..4c157302365f 100644 > --- a/drivers/cpufreq/exynos-cpufreq.c > +++ b/drivers/cpufreq/exynos-cpufreq.c > @@ -10,6 +10,7 @@ > */ > > #include <linux/kernel.h> > +#include <linux/module.h> > #include <linux/err.h> > #include <linux/clk.h> > #include <linux/io.h> >
On 16.06.2015 08:47, Rafael J. Wysocki wrote: > On Wednesday, June 03, 2015 05:18:18 PM Paul Gortmaker wrote: >> This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") >> and also contains modular function calls so it should explicitly include >> module.h to avoid compile breakage during pending header shuffles. >> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: Kukjin Kim <kgene@kernel.org> >> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> Cc: linux-pm@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-samsung-soc@vger.kernel.org >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > I'm assuming that this will go in via the Samsung tree. > > >> --- >> >> [ patch will be appended to the implicit include fixup series, see: >> https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com >> for the original series posting.] Paul, will you handle the patch or should it go through Samsung tree? Best regards, Krzysztof
On Mon, Jun 15, 2015 at 7:53 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 16.06.2015 08:47, Rafael J. Wysocki wrote: >> On Wednesday, June 03, 2015 05:18:18 PM Paul Gortmaker wrote: >>> This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") >>> and also contains modular function calls so it should explicitly include >>> module.h to avoid compile breakage during pending header shuffles. >>> >>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >>> Cc: Viresh Kumar <viresh.kumar@linaro.org> >>> Cc: Kukjin Kim <kgene@kernel.org> >>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> Cc: linux-pm@vger.kernel.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-samsung-soc@vger.kernel.org >>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> >> I'm assuming that this will go in via the Samsung tree. >> >> >>> --- >>> >>> [ patch will be appended to the implicit include fixup series, see: >>> https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com >>> for the original series posting.] > > Paul, will you handle the patch or should it go through Samsung tree? My fault for not explicitly stating the obvious... If I don't keep the patch locally (or at least a version of it) then we can introduce a compile bisection fail. So I will keep all patches locally unless there is a rebase where I can (also) rebase and drop said pach since it has become common history of the shared baseline... Paul. -- > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On 15-06-15 07:53 PM, Krzysztof Kozlowski wrote: > On 16.06.2015 08:47, Rafael J. Wysocki wrote: >> On Wednesday, June 03, 2015 05:18:18 PM Paul Gortmaker wrote: >>> This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") >>> and also contains modular function calls so it should explicitly include >>> module.h to avoid compile breakage during pending header shuffles. >>> >>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >>> Cc: Viresh Kumar <viresh.kumar@linaro.org> >>> Cc: Kukjin Kim <kgene@kernel.org> >>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> Cc: linux-pm@vger.kernel.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-samsung-soc@vger.kernel.org >>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> >> I'm assuming that this will go in via the Samsung tree. >> >> >>> --- >>> >>> [ patch will be appended to the implicit include fixup series, see: >>> https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com >>> for the original series posting.] > > Paul, will you handle the patch or should it go through Samsung tree? I have to keep a copy of the patch in the above series, since if I don't then we'll introduce build failures into the bisection history, so yes I'll handle it. Thanks, Paul. -- > > Best regards, > Krzysztof >
On 17.06.2015 00:29, Paul Gortmaker wrote: > On 15-06-15 07:53 PM, Krzysztof Kozlowski wrote: >> On 16.06.2015 08:47, Rafael J. Wysocki wrote: >>> On Wednesday, June 03, 2015 05:18:18 PM Paul Gortmaker wrote: >>>> This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") >>>> and also contains modular function calls so it should explicitly include >>>> module.h to avoid compile breakage during pending header shuffles. >>>> >>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >>>> Cc: Viresh Kumar <viresh.kumar@linaro.org> >>>> Cc: Kukjin Kim <kgene@kernel.org> >>>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>>> Cc: linux-pm@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-samsung-soc@vger.kernel.org >>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >>> >>> I'm assuming that this will go in via the Samsung tree. >>> >>> >>>> --- >>>> >>>> [ patch will be appended to the implicit include fixup series, see: >>>> https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com >>>> for the original series posting.] >> >> Paul, will you handle the patch or should it go through Samsung tree? > > > I have to keep a copy of the patch in the above series, since if > I don't then we'll introduce build failures into the bisection > history, so yes I'll handle it. Thank you, I'll leave the patch for you to handle. Best regards, Krzysztof
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 82d2fbb20f7e..4c157302365f 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -10,6 +10,7 @@ */ #include <linux/kernel.h> +#include <linux/module.h> #include <linux/err.h> #include <linux/clk.h> #include <linux/io.h>
This file is built off of a tristate Kconfig option ("ARM_EXYNOS_CPUFREQ") and also contains modular function calls so it should explicitly include module.h to avoid compile breakage during pending header shuffles. Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- [ patch will be appended to the implicit include fixup series, see: https://lkml.kernel.org/r/1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com for the original series posting.] drivers/cpufreq/exynos-cpufreq.c | 1 + 1 file changed, 1 insertion(+)