From patchwork Mon Jun 15 04:37:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 6606001 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 67DF29F326 for ; Mon, 15 Jun 2015 04:42:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A350420562 for ; Mon, 15 Jun 2015 04:42:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A66F6204D6 for ; Mon, 15 Jun 2015 04:42:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4MAH-0008C0-0Z; Mon, 15 Jun 2015 04:38:29 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4MAD-0008Aa-Ug for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2015 04:38:26 +0000 Received: from localhost.localdomain ([178.25.78.242]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0ME295-1YnbR716Xn-00HMoF; Mon, 15 Jun 2015 06:37:54 +0200 From: Stefan Wahren To: Felipe Balbi , Greg Kroah-Hartman Subject: [PATCH] phy: phy-mxs-usb: suspend to RAM causes NULL pointer dereference Date: Mon, 15 Jun 2015 04:37:00 +0000 Message-Id: <1434343020-29604-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 X-Provags-ID: V03:K0:f1OMmNwZdxYNdTyC3FVqxjk3KnrTG2swmq5sIXTqUvhP91GxuZy tgaiFYdy9HDYho57yYfqls5XNijfwXSdJAtO8SJvyt7N59UU+hNrtY5+bsx+Jzy1seXwkLY wDUGD+yqGpw2LTm3RMogBNGexvJG5p6SU/ftmvibBfkN3yIlFk5G0k4jHOUQtHMV/QkqleI n6UJ/pL9uUo+7anVZrz1g== X-UI-Out-Filterresults: notjunk:1; V01:K0:PSXuAzBFDF0=:a22/3jaICn4S7wxZna/Cfk 10VZGHRGPgszBYJZl+1ojzWKMfeRvnonNJJH6sJT6AMEXLHlKwOnrHh/rpR7jV2i95NUqGFnL /8Z1ELUwC9d+UlLcfuM7h7+1zny75V7c4Y9v9kSE7HTx4q0M4LpJ7BEALmgndrkA7oGtZNdko JjYxbV+9Ol2G/tCZ1srQv4AI6N5Aj51W5KiS7jYvoAT1leXcURJQ4cToB7og8omJVVAbpFdjF kEFlKh/6c9j8nw7yThaLlg3/Xmtj0wtO3wI1uzPNp4lwBSR3eLb+rOvlEWEsXe8T432EpnUXY Ko9XnIZ8t+X0hUnJMX9Pq3bQEOl1DpPJ6n/kzmNObqZxLWM5x6KPpYQOGFEHbeOlPrrCRMCV3 1io1cGef6g+cDAMakHdNq0wQn8u8/dgoWP3i/BzVonP5xztEj5lQ+BumZrkk8WzDl8pWtL/7A QWs94Fhu/wpZpTgVYupOBVJej4+5ZHBpxwaf8TnpZrN7XwMTZynSSnWfJmtoKLESX2iNr4lc+ T7LIeSYkPqalvQ6PxuWd9iPC+04Q3XjiekCIOYeUmH5ZECiloEYvE5GQCBEC8u7WxTjBluJ51 cf41GNINgUDK49LhD5124KRsiQgKQzDd25vmKSp0Vi3qY7NXDRxP19Ow3vNU/8iUodbKE72x0 IfIVog9EzQuMzXgQHteeWF8b8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150614_213826_346741_46DD5A01 X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) Cc: marex@denx.de, fabio.estevam@freescale.com, Stefan Wahren , linux-usb@vger.kernel.org, j.uzycki@elproma.com.pl, peter.chen@freescale.com, linux-arm-kernel@lists.infradead.org, LW@karo-electronics.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer dereference. This patch avoids the oops in mxs_phy_get_vbus_status() by aborting since there is no syscon available. Signed-off-by: Stefan Wahren Fixes: efdbd3a5d6e ("usb: phy: mxs: do not set PWD.RXPWD1PT1 for low speed connection") CC: # 4.0 Acked-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 8f7cb06..3fcc048 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -217,6 +217,9 @@ static bool mxs_phy_get_vbus_status(struct mxs_phy *mxs_phy) { unsigned int vbus_value; + if (!mxs_phy->regmap_anatop) + return false; + if (mxs_phy->port_id == 0) regmap_read(mxs_phy->regmap_anatop, ANADIG_USB1_VBUS_DET_STAT,