From patchwork Mon Jun 15 15:49:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 6610241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 24C2D9F326 for ; Mon, 15 Jun 2015 15:56:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 51232205D1 for ; Mon, 15 Jun 2015 15:56:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D93920552 for ; Mon, 15 Jun 2015 15:56:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4Wi1-0000CB-L8; Mon, 15 Jun 2015 15:54:01 +0000 Received: from mail-pd0-f182.google.com ([209.85.192.182]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4Whf-0008Sz-1x for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2015 15:53:40 +0000 Received: by pdbki1 with SMTP id ki1so75742285pdb.1 for ; Mon, 15 Jun 2015 08:53:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8NRG7RWk7bjIR8OJ7lWOSEzfCzjwvHukwzWQUQEJvQQ=; b=Sn1gHukW9c0vjZGyEaIkPc0t5lNa8e41JnZJqgSnAFBlx1FMTuNbFZAFpv4JZ8isGr loqK9z/XPm4LwyiLIXullV8E7lK8Akk2Vga9LP2cCKA8+C+HWw/o4/yEN+RATDJuN4cM eAd0UI5lUro1z4ZrhGZoC9O+HeonEXcC2c5f74cCH6DG9VPlRBYAwHfgcwdpi0F5Q68d g9tIrxvD2NhyjpXtHoGt2skwRLj4ggoxomZR0DAA+aPt8Lhk9dCeqiVZG4Zdz37f17Gg KEvQSezJvwuAnPkaCQRoikYLjTchtAL55MFiRvBd8gWJRbrTDgviJ9Q/01C3XYdYhJvI ypWw== X-Gm-Message-State: ALoCoQnSF1+VAabPiMTd/PXH/J3OK9ISDjEndBJuf0P8CzYv/ZjdzVRSSkY/zhy0+JNfBGTyTag+ X-Received: by 10.68.110.3 with SMTP id hw3mr48934137pbb.128.1434383597653; Mon, 15 Jun 2015 08:53:17 -0700 (PDT) Received: from localhost.localdomain ([202.62.77.106]) by mx.google.com with ESMTPSA id fs16sm12662484pdb.12.2015.06.15.08.53.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Jun 2015 08:53:16 -0700 (PDT) From: Vaibhav Hiremath To: linux-i2c@vger.kernel.org Subject: [PATCH-V2 01/12] i2c: pxa: keep i2c irq ON in suspend Date: Mon, 15 Jun 2015 21:19:48 +0530 Message-Id: <1434383399-2370-2-git-send-email-vaibhav.hiremath@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150615_085339_173049_8D024AAB X-CRM114-Status: GOOD ( 10.37 ) X-Spam-Score: -0.7 (/) Cc: Leilei Shang , wsa@the-dreams.de, Vaibhav Hiremath , Raul Xiong , Xiaofan Tian , robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Leilei Shang During suspend there may still be some i2c access happening, as the interrupt is shared between multiple drivers. And if we don't keep i2c irq ON, there may be i2c access timeout if i2c is in irq mode of operation. Signed-off-by: Raul Xiong Signed-off-by: Xiaofan Tian [vaibhav.hiremath@linaro.org: updated Changelog] Signed-off-by: Vaibhav Hiremath Cc: Wolfram Sang --- drivers/i2c/busses/i2c-pxa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index d9c0d6a..f4ac8c5 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1232,8 +1232,9 @@ static int i2c_pxa_probe(struct platform_device *dev) i2c->adap.algo = &i2c_pxa_pio_algorithm; } else { i2c->adap.algo = &i2c_pxa_algorithm; - ret = request_irq(irq, i2c_pxa_handler, IRQF_SHARED, - dev_name(&dev->dev), i2c); + ret = request_irq(irq, i2c_pxa_handler, + IRQF_SHARED | IRQF_NO_SUSPEND, + dev_name(&dev->dev), i2c); if (ret) goto ereqirq; }